Skip to content

Commit b288d5e

Browse files
committed
fix: remove unnecessary search landmark nested in <search>
The `<search>` element’s implicit ARIA role is `search`, so setting `role=search` on the nested `<form>` is redundant and adds noise.
1 parent 0160744 commit b288d5e

3 files changed

Lines changed: 1 addition & 3 deletions

File tree

app/components/AppHeader.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ onKeyStroke(',', e => {
7575
<!-- Search bar (shown on all pages except home and search) -->
7676
<search v-if="showSearchBar" class="hidden sm:block flex-1 max-w-md">
7777
<form
78-
role="search"
7978
method="GET"
8079
action="/search"
8180
class="relative"

app/pages/index.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ defineOgImageComponent('Default')
5050
style="animation-delay: 0.2s"
5151
>
5252
<form
53-
role="search"
5453
method="GET"
5554
action="/search"
5655
class="relative"

app/pages/search.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -722,7 +722,7 @@ defineOgImageComponent('Default', {
722722
<h1 class="font-mono text-xl sm:text-2xl font-medium mb-4">{{ $t('nav.search') }}</h1>
723723

724724
<search>
725-
<form role="search" method="GET" action="/search" class="relative" @submit.prevent>
725+
<form method="GET" action="/search" class="relative" @submit.prevent>
726726
<label for="search-input" class="sr-only">{{ $t('search.label') }}</label>
727727

728728
<div class="relative group" :class="{ 'is-focused': isSearchFocused }">

0 commit comments

Comments
 (0)