feat: apply review

btea · btea · commit b2de7a0c0849 · 2026-02-28T11:22:27.000+08:00
diff --git a/shared/types/env.ts b/shared/types/env.ts
@@ -8,5 +8,5 @@ export interface BuildInfo {
   branch: string
   env: EnvType
   privacyPolicyDate: string
-  prNumber: string | number | null
+  prNumber: string | null
 }
diff --git a/test/nuxt/components/BuildEnvironment.spec.ts b/test/nuxt/components/BuildEnvironment.spec.ts
@@ -13,6 +13,7 @@ describe('BuildEnvironment', () => {
       shortCommit: 'abc',
       branch: 'main',
       privacyPolicyDate: new Date().toISOString(),
+      prNumber: null,
     }
     const component = await mountSuspended(BuildEnvironment, {
       props: {
@@ -39,6 +40,7 @@ describe('BuildEnvironment', () => {
       shortCommit: 'abc',
       branch: 'release',
       privacyPolicyDate: new Date().toISOString(),
+      prNumber: null,
     }
 
     const component = await mountSuspended(BuildEnvironment, {

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@ describe('BuildEnvironment', () => {`
`13`	`13`	`shortCommit: 'abc',`
`14`	`14`	`branch: 'main',`
`15`	`15`	`privacyPolicyDate: new Date().toISOString(),`
	`16`	`+ prNumber: null,`
`16`	`17`	`}`
`17`	`18`	`const component = await mountSuspended(BuildEnvironment, {`
`18`	`19`	`props: {`
`@@ -39,6 +40,7 @@ describe('BuildEnvironment', () => {`
`39`	`40`	`shortCommit: 'abc',`
`40`	`41`	`branch: 'release',`
`41`	`42`	`privacyPolicyDate: new Date().toISOString(),`
	`43`	`+ prNumber: null,`
`42`	`44`	`}`
`43`	`45`
`44`	`46`	`const component = await mountSuspended(BuildEnvironment, {`