fix: detect file modifications using hashes

Author: taskylizard

server/utils/compare.ts

@@ -1,10 +1,5 @@
 import { diff as semverDiff } from 'semver'
-import type {
-  PackageFileTree,
-  DependencyChange,
-  FileChange,
-  CompareResponse,
-} from '#shared/types'
+import type { PackageFileTree, DependencyChange, FileChange, CompareResponse } from '#shared/types'
 
 /** Maximum number of files to include in comparison */
 const MAX_FILES_COMPARE = 1000
@@ -34,6 +29,17 @@ export function compareFileTrees(
   const fromFiles = flattenTree(fromTree)
   const toFiles = flattenTree(toTree)
 
+  const hasChanged = (fromNode: PackageFileTree, toNode: PackageFileTree): boolean => {
+    // Prefer strong hash comparison when both hashes are available
+    if (fromNode.hash && toNode.hash) return fromNode.hash !== toNode.hash
+    // Fallback to size comparison if hashes are missing
+    if (typeof fromNode.size === 'number' && typeof toNode.size === 'number') {
+      return fromNode.size !== toNode.size
+    }
+    // If we lack comparable signals, assume unchanged
+    return false
+  }
+
   const added: FileChange[] = []
   const removed: FileChange[] = []
   const modified: FileChange[] = []
@@ -58,8 +64,7 @@ export function compareFileTrees(
         newSize: toNode.size,
       })
     } else if (fromNode.type === 'file') {
-      // Check if modified (size changed)
-      if (fromNode.size !== toNode.size) {
+      if (hasChanged(fromNode, toNode)) {
         modified.push({
           path,
           type: 'modified',
@@ -135,7 +140,11 @@ export function compareDependencies(
           const cleanTo = toVersion.replace(/^[\^~>=<]+/, '')
           const diffResult = semverDiff(cleanFrom, cleanTo)
           if (diffResult) {
-            if (diffResult === 'premajor' || diffResult === 'preminor' || diffResult === 'prepatch') {
+            if (
+              diffResult === 'premajor' ||
+              diffResult === 'preminor' ||
+              diffResult === 'prepatch'
+            ) {
               semverDiffType = 'prerelease'
             } else if (['major', 'minor', 'patch', 'prerelease'].includes(diffResult)) {
               semverDiffType = diffResult as 'major' | 'minor' | 'patch' | 'prerelease'

server/utils/file-tree.ts

@@ -50,6 +50,7 @@ export function convertToFileTree(
         name: node.name,
         path,
         type: 'file',
+        hash: node.hash,
         size: node.size,
       })
     }

shared/types/npm-registry.ts

@@ -298,6 +298,8 @@ export interface PackageFileTree {
   path: string
   /** Node type */
   type: 'file' | 'directory'
+  /** File hash (only for files) */
+  hash?: string
   /** File size in bytes (only for files) */
   size?: number
   /** Child nodes (only for directories) */