Skip to content

Commit b543c8b

Browse files
test: use data-testid instead of relying on classes
1 parent c05e110 commit b543c8b

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

app/components/PackageVersions.vue

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,7 @@ function getTagVersions(tag: string): VersionDisplay[] {
318318
<span
319319
v-if="loadingTags.has(row.tag)"
320320
class="i-carbon-rotate-180 w-3 h-3 motion-safe:animate-spin"
321+
data-testid="loading-spinner"
321322
aria-hidden="true"
322323
/>
323324
<span
@@ -458,6 +459,7 @@ function getTagVersions(tag: string): VersionDisplay[] {
458459
<span
459460
v-if="otherVersionsLoading"
460461
class="i-carbon-rotate-180 w-3 h-3 motion-safe:animate-spin"
462+
data-testid="loading-spinner"
461463
aria-hidden="true"
462464
/>
463465
<span

test/nuxt/components/PackageVersions.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -782,7 +782,7 @@ describe('PackageVersions', () => {
782782

783783
// Should show loading spinner (animate-spin class)
784784
await vi.waitFor(() => {
785-
expect(component.find('.animate-spin').exists()).toBe(true)
785+
expect(component.find('[data-testid="loading-spinner"]').exists()).toBe(true)
786786
})
787787

788788
// Resolve the promise to clean up
@@ -816,7 +816,7 @@ describe('PackageVersions', () => {
816816

817817
// Should show loading spinner
818818
await vi.waitFor(() => {
819-
expect(component.find('.animate-spin').exists()).toBe(true)
819+
expect(component.find('[data-testid="loading-spinner"]').exists()).toBe(true)
820820
})
821821

822822
// Resolve the promise to clean up

0 commit comments

Comments
 (0)