Skip to content

Commit bff1505

Browse files
committed
feat: flip the wording for old versions so we default to hiding them
1 parent b6e063a commit bff1505

5 files changed

Lines changed: 16 additions & 16 deletions

File tree

app/components/Package/VersionDistribution.vue

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ const isMobile = computed(() => width.value > 0 && width.value < mobileBreakpoin
7070
7171
const {
7272
groupingMode,
73-
hideSmallVersions,
73+
showOldVersions,
7474
showLowUsageVersions,
7575
pending,
7676
error,
@@ -113,7 +113,7 @@ const chartConfig = computed(() => {
113113
useNiceScale: true,
114114
},
115115
xAxisLabels: {
116-
show: true,
116+
show: xAxisLabels.value.length <= 25,
117117
values: xAxisLabels.value,
118118
fontSize: isMobile.value ? 14 : 12,
119119
color: colors.value.fgSubtle,
@@ -365,9 +365,9 @@ const endDate = computed(() => {
365365

366366
<div class="flex flex-col gap-4 w-full max-w-1/2">
367367
<SettingsToggle
368-
v-model="hideSmallVersions"
369-
:label="$t('package.versions.hide_old_versions')"
370-
:tooltip="$t('package.versions.hide_old_versions_tooltip')"
368+
v-model="showOldVersions"
369+
:label="$t('package.versions.show_old_versions')"
370+
:tooltip="$t('package.versions.show_old_versions_tooltip')"
371371
tooltip-position="bottom"
372372
:tooltip-teleport-to="inModal ? '#chart-modal' : undefined"
373373
:tooltip-offset="8"

app/composables/useVersionDistribution.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ interface ChartDataItem {
2222
*/
2323
export function useVersionDistribution(packageName: MaybeRefOrGetter<string>) {
2424
const groupingMode = ref<VersionGroupingMode>('major')
25-
const hideSmallVersions = ref(false)
25+
const showOldVersions = ref(false)
2626
const showLowUsageVersions = ref(false)
2727
const pending = ref(false)
2828
const error = ref<Error | null>(null)
@@ -48,7 +48,7 @@ export function useVersionDistribution(packageName: MaybeRefOrGetter<string>) {
4848
{
4949
query: {
5050
mode,
51-
filterOldVersions: hideSmallVersions.value ? 'true' : 'false',
51+
filterOldVersions: showOldVersions.value ? 'false' : 'true',
5252
filterThreshold: showLowUsageVersions.value ? '0' : '1',
5353
},
5454
},
@@ -73,7 +73,7 @@ export function useVersionDistribution(packageName: MaybeRefOrGetter<string>) {
7373
let groups = data.value.groups
7474

7575
// Filter using server-provided recent versions list
76-
if (hideSmallVersions.value && data.value.recentVersions) {
76+
if (!showOldVersions.value && data.value.recentVersions) {
7777
const recentVersionsSet = new Set(data.value.recentVersions)
7878

7979
groups = groups.filter(group => {
@@ -130,7 +130,7 @@ export function useVersionDistribution(packageName: MaybeRefOrGetter<string>) {
130130
})
131131

132132
// Refetch when filter changes - no immediate since we already have data
133-
watch(hideSmallVersions, () => {
133+
watch(showOldVersions, () => {
134134
fetchDistribution()
135135
})
136136

@@ -159,7 +159,7 @@ export function useVersionDistribution(packageName: MaybeRefOrGetter<string>) {
159159
return {
160160
// State
161161
groupingMode,
162-
hideSmallVersions,
162+
showOldVersions,
163163
showLowUsageVersions,
164164
pending,
165165
error,

i18n/locales/en.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,8 +281,8 @@
281281
"distribution_modal_title": "Versions",
282282
"grouping_major": "Major",
283283
"grouping_minor": "Minor",
284-
"hide_old_versions": "Hide old versions",
285-
"hide_old_versions_tooltip": "Hide versions older than 1 year",
284+
"show_old_versions": "Show old versions",
285+
"show_old_versions_tooltip": "Show versions older than 1 year",
286286
"show_low_usage": "Show low usage versions",
287287
"show_low_usage_tooltip": "Include version groups with less than 1% of total downloads",
288288
"date_range_tooltip": "Last week of version distributions only"

lunaria/files/en-GB.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,8 +281,8 @@
281281
"distribution_modal_title": "Versions",
282282
"grouping_major": "Major",
283283
"grouping_minor": "Minor",
284-
"hide_old_versions": "Hide old versions",
285-
"hide_old_versions_tooltip": "Hide versions older than 1 year",
284+
"show_old_versions": "Show old versions",
285+
"show_old_versions_tooltip": "Show versions older than 1 year",
286286
"show_low_usage": "Show low usage versions",
287287
"show_low_usage_tooltip": "Include version groups with less than 1% of total downloads",
288288
"date_range_tooltip": "Last week of version distributions only"

lunaria/files/en-US.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,8 +281,8 @@
281281
"distribution_modal_title": "Versions",
282282
"grouping_major": "Major",
283283
"grouping_minor": "Minor",
284-
"hide_old_versions": "Hide old versions",
285-
"hide_old_versions_tooltip": "Hide versions older than 1 year",
284+
"show_old_versions": "Show old versions",
285+
"show_old_versions_tooltip": "Show versions older than 1 year",
286286
"show_low_usage": "Show low usage versions",
287287
"show_low_usage_tooltip": "Include version groups with less than 1% of total downloads",
288288
"date_range_tooltip": "Last week of version distributions only"

0 commit comments

Comments
 (0)