wip

Author: gameroman

app/composables/usePackageComparison.ts

@@ -8,7 +8,7 @@ import type {
 import { encodePackageName } from '#shared/utils/npm'
 import type { PackageAnalysisResponse } from './usePackageAnalysis'
 import { isBinaryOnlyPackage } from '#shared/utils/binary-detection'
-import { getDependencyCount } from '~/utils/npm/common'
+import { getDependencyCount } from '~/utils/npm/dependency-count'
 
 export interface PackageComparisonData {
   package: ComparisonPackage
@@ -114,6 +114,7 @@ export function usePackageComparison(packageNames: MaybeRefOrGetter<string[]>) {
             ])
 
             const pkg = usePackage(name, latestVersion)
+            const requestedVersion = pkg.data.value?.requestedVersion
 
             const versionData = pkgData.versions[latestVersion]
             const packageSize = versionData?.dist?.unpackedSize
@@ -145,7 +146,7 @@ export function usePackageComparison(packageNames: MaybeRefOrGetter<string[]>) {
               },
               downloads: downloads?.downloads,
               packageSize,
-              directDeps: getDependencyCount(pkg.data.value?.requestedVersion ?? null),
+              directDeps: getDependencyCount(requestedVersion ?? null),
               installSize: undefined, // Will be filled in second pass
               analysis: analysis ?? undefined,
               vulnerabilities: {
@@ -367,11 +368,12 @@ function computeFacetValue(
       }
 
     case 'dependencies':
+      if (!data.directDeps) return null
       const depCount = data.directDeps
       return {
         raw: depCount,
         display: String(depCount),
-        status: depCount > 50 ? 'warning' : 'neutral',
+        status: depCount > 10 ? 'warning' : 'neutral',
       }
 
     case 'deprecated':

app/pages/package/[...package].vue

@@ -11,7 +11,7 @@ import { joinURL } from 'ufo'
 import { areUrlsEquivalent } from '#shared/utils/url'
 import { isEditableElement } from '~/utils/input'
 import { formatBytes } from '~/utils/formatters'
-import { getDependencyCount } from '~/utils/npm/common'
+import { getDependencyCount } from '~/utils/npm/dependency-count'
 import { NuxtLink } from '#components'
 
 definePageMeta({

app/utils/npm/common.ts

@@ -12,8 +12,3 @@ export const NPM_API = 'https://api.npmjs.org'
 export function buildScopeTeam(orgName: string, teamName: string): `@${string}:${string}` {
   return `@${orgName.replace(/^@/, '')}:${teamName}`
 }
-
-export function getDependencyCount(version: PackumentVersion | null): number {
-  if (!version?.dependencies) return 0
-  return Object.keys(version.dependencies).length
-}

app/utils/npm/dependency-count.ts

@@ -0,0 +1,6 @@
+import type { PackumentVersion } from '#shared/types'
+
+export function getDependencyCount(version: PackumentVersion | null): number {
+  if (!version?.dependencies) return 0
+  return Object.keys(version.dependencies).length
+}