fix: follow the rabbit

Author: graphieros

app/components/Compare/FacetScatterChart.vue

@@ -296,7 +296,7 @@ const step = shallowRef(0)
           id="select-facet-scatter-x"
           v-model="selectedFacetX"
           :items="chartableFacets.map(f => ({ label: resolveAxisLabel(f.name), value: f.name }))"
-          :label="'X-AXIS'"
+          :label="$t('compare.scatter_chart.x_axis')"
           size="sm"
           block
           @change="step += 1"
@@ -306,7 +306,7 @@ const step = shallowRef(0)
           id="select-facet-scatter-y"
           v-model="selectedFacetY"
           :items="chartableFacets.map(f => ({ label: resolveAxisLabel(f.name), value: f.name }))"
-          :label="'Y-AXIS'"
+          :label="$t('compare.scatter_chart.y_axis')"
           size="sm"
           block
           @change="step += 1"

app/utils/compare-scatter-chart.ts

@@ -28,7 +28,7 @@ function toFreshnessScore(value: unknown, maximumAgeInDays = 365): number | null
   }
 
   if (normalizedFreshness > 1) {
-    return 1
+    return 100
   }
 
   return normalizedFreshness * 100

i18n/locales/en.json

@@ -1243,7 +1243,9 @@
         "analysis": "{package} : {x_name} ({x_value}) and {y_name} ({y_value})",
         "description": "Scatter plot chart mapping {x_name} versus {y_name} for the {packages} packages. {analysis}. {watermark}"
       },
-      "filename": "{x}-vs-{y}-scatter-chart"
+      "filename": "{x}-vs-{y}-scatter-chart",
+      "x_axis": "X-AXIS",
+      "y_axis": "Y-AXIS"
     },
     "no_dependency": {
       "label": "(No dependency)",

i18n/locales/fr-FR.json

@@ -1234,13 +1234,15 @@
       "add_hint": "Ajoutez au moins 2 paquets à comparer."
     },
     "scatter_chart": {
-      "title": "Comparaison {x} vs ${y}",
+      "title": "Comparaison {x} vs {y}",
       "freshness_score": "Score de récence",
       "copy_alt": {
         "analysis": "{package} : {x_name} ({x_value}) et {y_name} ({y_value})",
         "description": "Graphique en nuage de points représentant {x_name} en fonction de {y_name} pour les paquets {packages}. {analysis}. {watermark}"
       },
-      "filename": "{x}-vs-{y}-scatter-chart"
+      "filename": "{x}-vs-{y}-scatter-chart",
+      "x_axis": "Abscisses",
+      "y_axis": "Ordonnées"
     },
     "no_dependency": {
       "label": "(Sans dépendance)",

i18n/schema.json

@@ -3735,6 +3735,12 @@
             },
             "filename": {
               "type": "string"
+            },
+            "x_axis": {
+              "type": "string"
+            },
+            "y_axis": {
+              "type": "string"
             }
           },
           "additionalProperties": false

test/unit/app/utils/compare-scatter-chart.spec.ts

@@ -659,7 +659,7 @@ describe('buildCompareScatterChartDataset', () => {
         color: undefined,
         values: [
           {
-            x: 1,
+            x: 100,
             y: 100,
             name: 'ellipsis(future-package,14)',
             fullName: 'future-package',