Skip to content

Commit cce854b

Browse files
committed
refactor: adjust label phrasing
Before: “none Performance” After: “deselect all Performance facets”
1 parent a1a3e7b commit cce854b

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

app/components/Compare/FacetSelector.vue

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,11 @@ function isCategoryNoneSelected(category: string): boolean {
3939
size="sm"
4040
data-facet-category-action="all"
4141
:data-facet-category="category"
42-
:aria-label="`${$t('compare.facets.all')} ${getCategoryLabel(category)}`"
42+
:aria-label="
43+
$t('compare.facets.select_all_category_facets', {
44+
category: getCategoryLabel(category),
45+
})
46+
"
4347
:aria-disabled="isCategoryAllSelected(category)"
4448
class="aria-disabled:(opacity-40 border-transparent)"
4549
@click="!isCategoryAllSelected(category) && selectCategory(category)"
@@ -53,7 +57,11 @@ function isCategoryNoneSelected(category: string): boolean {
5357
size="sm"
5458
data-facet-category-action="none"
5559
:data-facet-category="category"
56-
:aria-label="`${$t('compare.facets.none')} ${getCategoryLabel(category)}`"
60+
:aria-label="
61+
$t('compare.facets.deselect_all_category_facets', {
62+
category: getCategoryLabel(category),
63+
})
64+
"
5765
:aria-disabled="isCategoryNoneSelected(category)"
5866
class="aria-disabled:(opacity-40 border-transparent)"
5967
@click="!isCategoryNoneSelected(category) && deselectCategory(category)"

i18n/locales/en.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1129,6 +1129,8 @@
11291129
"facets": {
11301130
"all": "all",
11311131
"none": "none",
1132+
"select_all_category_facets": "Select all {category} facets",
1133+
"deselect_all_category_facets": "Deselect all {category} facets",
11321134
"coming_soon": "Coming soon",
11331135
"select_all": "Select all facets",
11341136
"deselect_all": "Deselect all facets",

0 commit comments

Comments
 (0)