Skip to content

Commit d169a85

Browse files
committed
chore: some fixes
1 parent b24d8b3 commit d169a85

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

test/nuxt/components/ConnectorModal.spec.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ import { mountSuspended } from '@nuxt/test-utils/runtime'
1010
import { ref, computed, readonly, nextTick } from 'vue'
1111
import type { VueWrapper } from '@vue/test-utils'
1212
import type { MockConnectorTestControls } from '../../../shared/test-utils'
13+
14+
/** Subset of MockConnectorTestControls for unit tests that don't need stateManager */
15+
type UnitTestConnectorControls = Omit<MockConnectorTestControls, 'stateManager'>
16+
import type { PendingOperation } from '../../../cli/src/types'
1317
import { ConnectorModal } from '#components'
1418

1519
// Mock state that will be controlled by tests
@@ -18,7 +22,7 @@ const mockState = ref({
1822
connecting: false,
1923
npmUser: null as string | null,
2024
avatar: null as string | null,
21-
operations: [] as Array<{ id: string; status: string }>,
25+
operations: [] as PendingOperation[],
2226
error: null as string | null,
2327
lastExecutionTime: null as number | null,
2428
})
@@ -81,8 +85,7 @@ function createMockUseConnector() {
8185
}
8286

8387
// Test controls for manipulating mock state
84-
const mockControls: MockConnectorTestControls = {
85-
stateManager: null as unknown as MockConnectorTestControls['stateManager'],
88+
const mockControls: UnitTestConnectorControls = {
8689
setOrgData: vi.fn(),
8790
setUserOrgs: vi.fn(),
8891
setUserPackages: vi.fn(),

tests/connector.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -404,13 +404,13 @@ test.describe('Package Access Controls', () => {
404404
test.describe('Operations Queue', () => {
405405
test('shows operations in connector modal', async ({ page, gotoConnected, mockConnector }) => {
406406
// Add some operations
407-
mockConnector.addOperation({
407+
await mockConnector.addOperation({
408408
type: 'org:add-user',
409409
params: { org: '@testorg', user: 'newuser', role: 'developer' },
410410
description: 'Add @newuser to @testorg as developer',
411411
command: 'npm org set @testorg newuser developer',
412412
})
413-
mockConnector.addOperation({
413+
await mockConnector.addOperation({
414414
type: 'org:rm-user',
415415
params: { org: '@testorg', user: 'olduser' },
416416
description: 'Remove @olduser from @testorg',
@@ -433,7 +433,7 @@ test.describe('Operations Queue', () => {
433433
})
434434

435435
test('can approve and execute operations', async ({ page, gotoConnected, mockConnector }) => {
436-
mockConnector.addOperation({
436+
await mockConnector.addOperation({
437437
type: 'org:add-user',
438438
params: { org: '@testorg', user: 'newuser', role: 'developer' },
439439
description: 'Add @newuser to @testorg',
@@ -473,7 +473,7 @@ test.describe('Operations Queue', () => {
473473
})
474474

475475
test('can clear pending operations', async ({ page, gotoConnected, mockConnector }) => {
476-
mockConnector.addOperation({
476+
await mockConnector.addOperation({
477477
type: 'org:add-user',
478478
params: { org: '@testorg', user: 'newuser', role: 'developer' },
479479
description: 'Add @newuser to @testorg',

0 commit comments

Comments
 (0)