Skip to content

Commit d3b4821

Browse files
fix: semver sorting
uses the built-in compare method from the semver package.
1 parent 3128fd0 commit d3b4821

1 file changed

Lines changed: 2 additions & 14 deletions

File tree

app/utils/versions.ts

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { valid } from 'semver'
1+
import { compare, valid } from 'semver'
22

33
/**
44
* Utilities for handling npm package versions and dist-tags
@@ -47,19 +47,7 @@ export function parseVersion(version: string): ParsedVersion {
4747
* @returns Comparison result for sorting
4848
*/
4949
export function compareVersions(a: string, b: string): number {
50-
const va = parseVersion(a)
51-
const vb = parseVersion(b)
52-
53-
if (va.major !== vb.major) return va.major - vb.major
54-
if (va.minor !== vb.minor) return va.minor - vb.minor
55-
if (va.patch !== vb.patch) return va.patch - vb.patch
56-
57-
// Stable versions (no prerelease) are greater than prereleases
58-
if (va.prerelease && vb.prerelease) return va.prerelease.localeCompare(vb.prerelease)
59-
if (va.prerelease) return -1
60-
if (vb.prerelease) return 1
61-
62-
return 0
50+
return compare(a, b)
6351
}
6452

6553
/**

0 commit comments

Comments
 (0)