Skip to content

Commit d8dfbf2

Browse files
authored
feat: add RTL support to PackageVersions (#350)
1 parent de331a5 commit d8dfbf2

2 files changed

Lines changed: 17 additions & 17 deletions

File tree

app/components/PackageVersions.vue

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ function getTagVersions(tag: string): VersionDisplay[] {
318318
>
319319
{{ $t('package.versions.title') }}
320320
<span
321-
class="i-carbon-link w-3 h-3 block opacity-0 group-hover:opacity-100 transition-opacity duration-200"
321+
class="i-carbon:link w-3 h-3 block opacity-0 group-hover:opacity-100 transition-opacity duration-200"
322322
aria-hidden="true"
323323
/>
324324
</a>
@@ -343,15 +343,15 @@ function getTagVersions(tag: string): VersionDisplay[] {
343343
>
344344
<span
345345
v-if="loadingTags.has(row.tag)"
346-
class="i-carbon-rotate-180 w-3 h-3 motion-safe:animate-spin"
346+
class="i-carbon:rotate-180 w-3 h-3 motion-safe:animate-spin"
347347
data-testid="loading-spinner"
348348
aria-hidden="true"
349349
/>
350350
<span
351351
v-else
352-
class="w-3 h-3 transition-transform duration-200"
352+
class="w-3 h-3 transition-transform duration-200 rtl-flip"
353353
:class="
354-
expandedTags.has(row.tag) ? 'i-carbon-chevron-down' : 'i-carbon-chevron-right'
354+
expandedTags.has(row.tag) ? 'i-carbon:chevron-down' : 'i-carbon:chevron-right'
355355
"
356356
aria-hidden="true"
357357
/>
@@ -412,7 +412,7 @@ function getTagVersions(tag: string): VersionDisplay[] {
412412
<!-- Expanded versions -->
413413
<div
414414
v-if="expandedTags.has(row.tag) && getTagVersions(row.tag).length > 1"
415-
class="ml-4 pl-2 border-l border-border space-y-0.5"
415+
class="ms-4 ps-2 border-is border-border space-y-0.5"
416416
>
417417
<div v-for="v in getTagVersions(row.tag).slice(1)" :key="v.version" class="py-1">
418418
<div class="flex items-center justify-between gap-2">
@@ -470,7 +470,7 @@ function getTagVersions(tag: string): VersionDisplay[] {
470470
<div class="pt-1">
471471
<button
472472
type="button"
473-
class="flex items-center gap-2 text-left focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-fg-muted focus-visible:ring-offset-1 focus-visible:ring-offset-bg rounded-sm"
473+
class="flex items-center gap-2 text-start focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-fg-muted focus-visible:ring-offset-1 focus-visible:ring-offset-bg rounded-sm"
474474
:aria-expanded="otherVersionsExpanded"
475475
:aria-label="
476476
otherVersionsExpanded
@@ -484,14 +484,14 @@ function getTagVersions(tag: string): VersionDisplay[] {
484484
>
485485
<span
486486
v-if="otherVersionsLoading"
487-
class="i-carbon-rotate-180 w-3 h-3 motion-safe:animate-spin"
487+
class="i-carbon:rotate-180 w-3 h-3 motion-safe:animate-spin"
488488
data-testid="loading-spinner"
489489
aria-hidden="true"
490490
/>
491491
<span
492492
v-else
493-
class="w-3 h-3 transition-transform duration-200"
494-
:class="otherVersionsExpanded ? 'i-carbon-chevron-down' : 'i-carbon-chevron-right'"
493+
class="w-3 h-3 transition-transform duration-200 rtl-flip"
494+
:class="otherVersionsExpanded ? 'i-carbon:chevron-down' : 'i-carbon:chevron-right'"
495495
aria-hidden="true"
496496
/>
497497
</span>
@@ -504,7 +504,7 @@ function getTagVersions(tag: string): VersionDisplay[] {
504504
</button>
505505

506506
<!-- Expanded other versions -->
507-
<div v-if="otherVersionsExpanded" class="ml-4 pl-2 border-l border-border space-y-0.5">
507+
<div v-if="otherVersionsExpanded" class="ms-4 ps-2 border-is border-border space-y-0.5">
508508
<!-- Hidden tag rows (overflow from visible tags) -->
509509
<div v-for="row in hiddenTagRows" :key="row.id" class="py-1">
510510
<div class="flex items-center justify-between gap-2">
@@ -568,11 +568,11 @@ function getTagVersions(tag: string): VersionDisplay[] {
568568
@click="toggleMajorGroup(group.groupKey)"
569569
>
570570
<span
571-
class="w-3 h-3 transition-transform duration-200"
571+
class="w-3 h-3 transition-transform duration-200 rtl-flip"
572572
:class="
573573
expandedMajorGroups.has(group.groupKey)
574-
? 'i-carbon-chevron-down'
575-
: 'i-carbon-chevron-right'
574+
? 'i-carbon:chevron-down'
575+
: 'i-carbon:chevron-right'
576576
"
577577
aria-hidden="true"
578578
/>
@@ -616,7 +616,7 @@ function getTagVersions(tag: string): VersionDisplay[] {
616616
</div>
617617
<div
618618
v-if="group.versions[0]?.tags?.length"
619-
class="flex items-center gap-1 ml-5 flex-wrap"
619+
class="flex items-center gap-1 ms-5 flex-wrap"
620620
>
621621
<span
622622
v-for="tag in group.versions[0].tags"
@@ -670,7 +670,7 @@ function getTagVersions(tag: string): VersionDisplay[] {
670670
/>
671671
</div>
672672
</div>
673-
<div v-if="group.versions[0]?.tags?.length" class="flex items-center gap-1 ml-5">
673+
<div v-if="group.versions[0]?.tags?.length" class="flex items-center gap-1 ms-5">
674674
<span
675675
v-for="tag in group.versions[0].tags"
676676
:key="tag"
@@ -684,7 +684,7 @@ function getTagVersions(tag: string): VersionDisplay[] {
684684
<!-- Version group versions -->
685685
<div
686686
v-if="expandedMajorGroups.has(group.groupKey) && group.versions.length > 1"
687-
class="ml-6 space-y-0.5"
687+
class="ms-6 space-y-0.5"
688688
>
689689
<div v-for="v in group.versions.slice(1)" :key="v.version" class="py-1">
690690
<div class="flex items-center justify-between gap-2">

test/nuxt/components/PackageVersions.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -943,7 +943,7 @@ describe('PackageVersions', () => {
943943
})
944944

945945
// Find chevron icons inside buttons
946-
const chevronIcons = component.findAll('button span.i-carbon-chevron-right')
946+
const chevronIcons = component.findAll('button span.i-carbon\\:chevron-right')
947947
expect(chevronIcons.length).toBeGreaterThan(0)
948948
for (const icon of chevronIcons) {
949949
expect(icon.attributes('aria-hidden')).toBe('true')

0 commit comments

Comments
 (0)