refactor: use lastIndexOf to avoid allocation

ShroXd · ShroXd · commit e2906da73a0b · 2026-03-10T09:10:44.000+08:00
diff --git a/app/utils/file-types.ts b/app/utils/file-types.ts
@@ -65,6 +65,7 @@ const BINARY_EXTENSIONS = new Set([
 ])
 
 export function isBinaryFilePath(filePath: string): boolean {
-  const ext = filePath.split('.').pop()?.toLowerCase() ?? ''
+  const dotIndex = filePath.lastIndexOf('.')
+  const ext = dotIndex > -1 ? filePath.slice(dotIndex + 1).toLowerCase() : ''
   return BINARY_EXTENSIONS.has(ext)
 }

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,7 @@ const BINARY_EXTENSIONS = new Set([`
`65`	`65`	`])`
`66`	`66`
`67`	`67`	`export function isBinaryFilePath(filePath: string): boolean {`
`68`		`- const ext = filePath.split('.').pop()?.toLowerCase() ?? ''`
	`68`	`+ const dotIndex = filePath.lastIndexOf('.')`
	`69`	`+ const ext = dotIndex > -1 ? filePath.slice(dotIndex + 1).toLowerCase() : ''`
`69`	`70`	`return BINARY_EXTENSIONS.has(ext)`
`70`	`71`	`}`