refactor: mitigate coderabbit concerns and refine codes

Author: shuuji3

scripts/i18n-meta/update-en-meta-json.ts

@@ -7,7 +7,7 @@ import {
   getCurrentCommitHash,
   getNewEnJson,
   getOldEnMetaJson,
-} from './git-utils.ts'
+} from './utils.ts'
 import type { EnJson, EnMetaJson, MetaEntry } from './types.d.ts'
 
 const enJsonPath = resolve('i18n/locales/en.json')
@@ -31,9 +31,9 @@ export function updateEnMetaJson() {
     return
   }
 
-  const finalMeta = createUpdatedEnMetaJson(currentCommitHash, enMetaJson)
+  const updatedEnMetaJson = createUpdatedEnMetaJson(currentCommitHash, enMetaJson)
 
-  writeFileSync(enMetaJsonPath, JSON.stringify(finalMeta, null, 2) + '\n', 'utf-8')
+  writeFileSync(enMetaJsonPath, JSON.stringify(updatedEnMetaJson, null, 2) + '\n', 'utf-8')
   console.log(`✅ Updated en.meta.json – last_updated_commit: ${currentCommitHash}`)
 }
 

scripts/i18n-meta/git-utils.ts scripts/i18n-meta/utils.tsscripts/i18n-meta/git-utils.ts renamed to scripts/i18n-meta/utils.ts

@@ -2,28 +2,15 @@ import { execSync } from 'node:child_process'
 import * as fs from 'node:fs'
 import type { EnJson, EnMetaJson } from './types.d.ts'
 
-export function git(command: string) {
-  try {
-    return execSync(`git ${command}`, { encoding: 'utf-8' }).trim()
-  } catch {
-    console.error(`🚨 Git command failed: git ${command}`)
-    return null
-  }
-}
-
-function readJson<T>(filePath: string): T {
-  return JSON.parse(fs.readFileSync(filePath, 'utf-8')) as T
-}
-
 export function getCurrentCommitHash() {
   return git('rev-parse HEAD')
 }
 
 export function getNewEnJson(enJsonPath: string): EnJson {
   if (fs.existsSync(enJsonPath)) {
-    return readJson<EnMetaJson>(enJsonPath)
+    return readJson<EnJson>(enJsonPath)
   }
-  return {} as EnMetaJson
+  return {} as EnJson
 }
 
 export function getOldEnMetaJson(enMetaJsonPath: string): EnMetaJson {
@@ -33,11 +20,6 @@ export function getOldEnMetaJson(enMetaJsonPath: string): EnMetaJson {
   return {} as EnMetaJson
 }
 
-function omitMeta<T extends object>(obj: T): Omit<T, '$meta'> {
-  const { $meta: _, ...rest } = obj as T & { $meta?: unknown }
-  return rest
-}
-
 export function checkTranslationChanges(oldMeta: EnMetaJson, newMeta: EnMetaJson): boolean {
   const oldObj = omitMeta(oldMeta)
   const newObj = omitMeta(newMeta)
@@ -53,6 +35,24 @@ export function createUpdatedEnMetaJson(
       last_updated_commit: commitHash,
       updated_at: new Date().toISOString(),
     },
-    ...content,
+    ...omitMeta(content),
   } as EnMetaJson
 }
+
+function git(command: string) {
+  try {
+    return execSync(`git ${command}`, { encoding: 'utf-8' }).trim()
+  } catch {
+    console.error(`🚨 Git command failed: git ${command}`)
+    return null
+  }
+}
+
+function readJson<T>(filePath: string): T {
+  return JSON.parse(fs.readFileSync(filePath, 'utf-8')) as T
+}
+
+function omitMeta<T extends object>(obj: T): Omit<T, '$meta'> {
+  const { $meta: _, ...rest } = obj as T & { $meta?: unknown }
+  return rest
+}