Skip to content

Commit e8ed065

Browse files
committed
feat: improve package main skeleton
1 parent 425e73c commit e8ed065

2 files changed

Lines changed: 26 additions & 26 deletions

File tree

app/components/Package/Skeleton.vue

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<template>
44
<!-- Package header — matches area-header in [...name].vue -->
5-
<header class="bg-[--bg] pt-2">
5+
<header class="bg-[--bg] pt-5 pb-1 w-full container">
66
<div class="min-w-0">
77
<!-- Package name -->
88
<div class="min-w-0 flex items-center gap-2 justify-between">
@@ -19,24 +19,24 @@
1919
</div>
2020
</header>
2121

22-
<div
23-
class="sticky top-14 z-1 pt-2 bg-bg border-b border-border flex flex-col md:flex-row-reverse flex-wrap gap-2 justify-between"
24-
>
25-
<!-- Version -->
26-
<span class="inline-flex items-baseline font-mono text-base sm:text-lg shrink-0">
27-
<SkeletonInline class="h-6 w-20" />
28-
</span>
29-
<!-- Docs + Code + Compare nav placeholder (hidden on mobile) -->
30-
<div class="flex items-center gap-0.5 p-0.5">
31-
<SkeletonInline class="h-7 w-22 rounded" />
32-
<SkeletonInline class="h-7 w-20 rounded" />
33-
<SkeletonInline class="h-7 w-26 rounded" />
22+
<div class="sticky top-14 z-1 pt-3 bg-bg border-b border-border w-full">
23+
<div class="w-full container flex flex-col md:flex-row-reverse flex-wrap gap-2 justify-between">
24+
<!-- Version -->
25+
<span class="inline-flex items-baseline font-mono text-base sm:text-lg shrink-0">
26+
<SkeletonInline class="h-6 w-20" />
27+
</span>
28+
<!-- Docs + Code + Compare nav placeholder (hidden on mobile) -->
29+
<div class="flex items-center gap-0.5 p-0.5">
30+
<SkeletonInline class="h-7 w-22 rounded" />
31+
<SkeletonInline class="h-7 w-20 rounded" />
32+
<SkeletonInline class="h-7 w-26 rounded" />
33+
</div>
3434
</div>
3535
</div>
3636
<article
3737
aria-busy="true"
3838
:aria-label="$t('package.skeleton.loading')"
39-
class="package-page motion-safe:animate-fade-in"
39+
class="package-page motion-safe:animate-fade-in container w-full"
4040
>
4141
<!-- Package details — matches area-details in [...name].vue -->
4242
<section class="area-details pt-4">
@@ -203,7 +203,7 @@
203203
<!-- Sidebar — matches area-sidebar in [...name].vue -->
204204
<div class="area-sidebar">
205205
<div
206-
class="sticky top-30 xl:top-14 space-y-6 sm:space-y-8 min-w-0 overflow-y-auto pe-2.5 lg:(max-h-[calc(100dvh-8.5rem)] overscroll-contain) xl:(pt-2 max-h-[calc(100dvh-6rem)])"
206+
class="sticky top-30 xl:top-14 space-y-6 sm:space-y-8 min-w-0 overflow-y-auto pe-2.5 lg:(max-h-[calc(100dvh-8.5rem)] overscroll-contain) xl:(max-h-[calc(100dvh-6rem)])"
207207
>
208208
<div class="flex flex-col gap-4 sm:gap-6 xl:pt-4">
209209
<!-- Download stats — matches CollapsibleSection + sparkline skeleton -->

app/pages/package/[[org]]/[name].vue

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -558,17 +558,6 @@ const showSkeleton = shallowRef(false)
558558
</ButtonBase>
559559
</DevOnly>
560560
<main class="flex-1 pb-8">
561-
<PackageHeader
562-
:pkg="pkg"
563-
:resolved-version="resolvedVersion"
564-
:display-version="displayVersion"
565-
:latest-version="latestVersion"
566-
:provenance-data="provenanceData"
567-
:provenance-status="provenanceStatus"
568-
:class="$style.areaHeader"
569-
page="main"
570-
:version-url-pattern="versionUrlPattern"
571-
/>
572561
<!-- Scenario 1: SPA fallback — show skeleton (no real content to preserve) -->
573562
<!-- Scenario 2: SSR with missing payload — preserve server DOM, skip skeleton -->
574563
<PackageSkeleton
@@ -593,6 +582,17 @@ const showSkeleton = shallowRef(false)
593582
/>
594583

595584
<template v-else-if="pkg">
585+
<PackageHeader
586+
:pkg="pkg"
587+
:resolved-version="resolvedVersion"
588+
:display-version="displayVersion"
589+
:latest-version="latestVersion"
590+
:provenance-data="provenanceData"
591+
:provenance-status="provenanceStatus"
592+
:class="$style.areaHeader"
593+
page="main"
594+
:version-url-pattern="versionUrlPattern"
595+
/>
596596
<article id="package-article" :class="$style.packagePage" class="container w-full">
597597
<!-- Package details -->
598598
<section :class="$style.areaDetails">

0 commit comments

Comments
 (0)