test coverage

Author: shamilkotta

test/nuxt/components/compare/FacetSelector.spec.ts

@@ -34,6 +34,16 @@ const categoryLabels: Record<string, string> = {
   security: 'Security & Compliance',
 }
 
+// ComingSoon tests run only when FACET_INFO has at least one comingSoon facet
+const comingSoonFacets = (Object.keys(FACET_INFO) as ComparisonFacet[]).filter(
+  f => FACET_INFO[f].comingSoon,
+)
+const hasComingSoonFacets = comingSoonFacets.length > 0
+const comingSoonFacetId = comingSoonFacets[0]
+const comingSoonFacetLabel = hasComingSoonFacets
+  ? (facetLabels[comingSoonFacetId!]?.label ?? comingSoonFacetId)
+  : ''
+
 // Helper to build facet info with labels
 function buildFacetInfo(facet: ComparisonFacet) {
   return {
@@ -174,13 +184,12 @@ describe('FacetSelector', () => {
     })
   })
 
-  describe('comingSoon facets', () => {
+  describe.runIf(hasComingSoonFacets)('comingSoon facets', () => {
     it('disables comingSoon facets', async () => {
       const component = await mountSuspended(FacetSelector)
 
-      // totalDependencies is marked as comingSoon
       const buttons = component.findAll('button')
-      const comingSoonButton = buttons.find(b => b.text().includes('Total Deps'))
+      const comingSoonButton = buttons.find(b => b.text().includes(comingSoonFacetLabel))
 
       expect(comingSoonButton?.attributes('disabled')).toBeDefined()
     })
@@ -194,11 +203,9 @@ describe('FacetSelector', () => {
     it('does not show checkmark/add icon for comingSoon facets', async () => {
       const component = await mountSuspended(FacetSelector)
 
-      // Find the comingSoon button
       const buttons = component.findAll('button')
-      const comingSoonButton = buttons.find(b => b.text().includes('Total Deps'))
+      const comingSoonButton = buttons.find(b => b.text().includes(comingSoonFacetLabel))
 
-      // Should not have checkmark or add icon
       expect(comingSoonButton?.find('.i-carbon\\:checkmark').exists()).toBe(false)
       expect(comingSoonButton?.find('.i-carbon\\:add').exists()).toBe(false)
     })
@@ -207,11 +214,10 @@ describe('FacetSelector', () => {
       const component = await mountSuspended(FacetSelector)
 
       const buttons = component.findAll('button')
-      const comingSoonButton = buttons.find(b => b.text().includes('Total Deps'))
+      const comingSoonButton = buttons.find(b => b.text().includes(comingSoonFacetLabel))
       await comingSoonButton?.trigger('click')
 
-      // toggleFacet should not have been called with totalDependencies
-      expect(mockToggleFacet).not.toHaveBeenCalledWith('totalDependencies')
+      expect(mockToggleFacet).not.toHaveBeenCalledWith(comingSoonFacetId)
     })
   })
 
@@ -281,7 +287,7 @@ describe('FacetSelector', () => {
       expect(component.find('.bg-bg-muted').exists()).toBe(true)
     })
 
-    it('applies cursor-not-allowed to comingSoon facets', async () => {
+    it.runIf(hasComingSoonFacets)('applies cursor-not-allowed to comingSoon facets', async () => {
       const component = await mountSuspended(FacetSelector)
 
       expect(component.find('.cursor-not-allowed').exists()).toBe(true)

test/nuxt/composables/use-facet-selection.spec.ts

@@ -2,7 +2,7 @@ import { beforeEach, describe, expect, it, vi } from 'vitest'
 import { mountSuspended } from '@nuxt/test-utils/runtime'
 import { ref } from 'vue'
 import type { ComparisonFacet } from '#shared/types/comparison'
-import { DEFAULT_FACETS, FACETS_BY_CATEGORY } from '#shared/types/comparison'
+import { DEFAULT_FACETS, FACET_INFO, FACETS_BY_CATEGORY } from '#shared/types/comparison'
 import type { FacetInfoWithLabels } from '~/composables/useFacetSelection'
 
 // Mock useRouteQuery - needs to be outside of the helper to persist across calls
@@ -113,15 +113,21 @@ describe('useFacetSelection', () => {
     expect(isFacetSelected('types')).toBe(true)
   })
 
-  it('filters out comingSoon facets from query', async () => {
-    mockRouteQuery.value = 'downloads,totalDependencies,types'
+  it.runIf((Object.keys(FACET_INFO) as ComparisonFacet[]).some(f => FACET_INFO[f].comingSoon))(
+    'filters out comingSoon facets from query',
+    async () => {
+      const comingSoonFacet = (Object.keys(FACET_INFO) as ComparisonFacet[]).find(
+        f => FACET_INFO[f].comingSoon,
+      )!
+      mockRouteQuery.value = `downloads,${comingSoonFacet},types`
 
-    const { isFacetSelected } = await useFacetSelectionInComponent()
+      const { isFacetSelected } = await useFacetSelectionInComponent()
 
-    expect(isFacetSelected('downloads')).toBe(true)
-    expect(isFacetSelected('types')).toBe(true)
-    expect(isFacetSelected('totalDependencies')).toBe(false)
-  })
+      expect(isFacetSelected('downloads')).toBe(true)
+      expect(isFacetSelected('types')).toBe(true)
+      expect(isFacetSelected(comingSoonFacet)).toBe(false)
+    },
+  )
 
   it('falls back to DEFAULT_FACETS if all parsed facets are invalid', async () => {
     mockRouteQuery.value = 'invalidFacet1,invalidFacet2'
@@ -225,7 +231,7 @@ describe('useFacetSelection', () => {
       selectCategory('performance')
 
       const performanceFacets = FACETS_BY_CATEGORY.performance.filter(
-        f => f !== 'totalDependencies', // comingSoon facet
+        f => !FACET_INFO[f].comingSoon,
       )
       for (const facet of performanceFacets) {
         expect(isFacetSelected(facet)).toBe(true)