fix: polish and cleanup post prototype

Author: devdumpling

app/pages/docs/[...path].vue

@@ -1,5 +1,6 @@
 <script setup lang="ts">
 import type { DocsResponse } from '#shared/types'
+import { assertValidPackageName } from '#shared/utils/npm'
 
 definePageMeta({
   name: 'docs',
@@ -28,6 +29,11 @@ const parsedRoute = computed(() => {
 const packageName = computed(() => parsedRoute.value.packageName)
 const requestedVersion = computed(() => parsedRoute.value.version)
 
+// Validate package name on server-side for early error detection
+if (import.meta.server && packageName.value) {
+  assertValidPackageName(packageName.value)
+}
+
 const { data: pkg } = usePackage(packageName)
 
 const latestVersion = computed(() => pkg.value?.['dist-tags']?.latest ?? null)
@@ -51,19 +57,21 @@ const docsUrl = computed(() => {
 
 const shouldFetch = computed(() => !!docsUrl.value)
 
-const { data: docsData, status: docsStatus } = useLazyFetch<DocsResponse>(() => docsUrl.value!, {
-  watch: [docsUrl],
-  immediate: shouldFetch.value,
-  default: () => ({
-    package: packageName.value,
-    version: resolvedVersion.value ?? '',
-    html: '',
-    toc: null,
-    breadcrumbs: null,
-    status: 'missing',
-    message: 'Docs are not available for this version.',
-  }),
-})
+const { data: docsData, status: docsStatus } = useLazyFetch<DocsResponse>(
+  () => docsUrl.value ?? '',
+  {
+    watch: [docsUrl],
+    immediate: shouldFetch.value,
+    default: () => ({
+      package: packageName.value,
+      version: resolvedVersion.value ?? '',
+      html: '',
+      toc: null,
+      status: 'missing',
+      message: 'Docs are not available for this version.',
+    }),
+  },
+)
 
 const pageTitle = computed(() => {
   if (!packageName.value) return 'API Docs - npmx'

pnpm-lock.yaml

@@ -1,7 +1,6 @@
 packages:
   - '.'
   - 'cli'
-  - 'prototypes/*'
 
 overrides:
   sharp: 0.34.5

pnpm-workspace.yaml

@@ -1,82 +1,49 @@
 import type { DocsResponse } from '#shared/types'
 import { fetchNpmPackage } from '#server/utils/npm'
-import { assertValidPackageName } from '#shared/utils/npm'
+import { assertValidPackageName, parsePackageParam } from '#shared/utils/npm'
 import { generateDocsWithDeno } from '#server/utils/docs'
 
 export default defineCachedEventHandler(
   async (event) => {
-    const segments = getRouterParam(event, 'pkg')?.split('/') ?? []
-    if (segments.length === 0) {
+    const pkgParam = getRouterParam(event, 'pkg')
+    if (!pkgParam) {
       throw createError({ statusCode: 400, message: 'Package name is required' })
     }
 
-    // Parse package name and optional version from URL segments
-    // Patterns: [pkg] or [pkg, 'v', version] or [@scope, pkg] or [@scope, pkg, 'v', version]
-    let packageName: string
-    let version: string | undefined
-
-    const vIndex = segments.indexOf('v')
-    if (vIndex !== -1 && vIndex < segments.length - 1) {
-      packageName = segments.slice(0, vIndex).join('/')
-      version = segments.slice(vIndex + 1).join('/')
-    }
-    else {
-      packageName = segments.join('/')
-    }
+    const { packageName, version: requestedVersion } = parsePackageParam(pkgParam)
 
     if (!packageName) {
       throw createError({ statusCode: 400, message: 'Package name is required' })
     }
     assertValidPackageName(packageName)
 
     const packument = await fetchNpmPackage(packageName)
-
-    if (!version) {
-      version = packument['dist-tags']?.latest
-    }
+    const version = requestedVersion ?? packument['dist-tags']?.latest
 
     if (!version) {
       throw createError({ statusCode: 404, message: 'No latest version found' })
     }
 
-    try {
-      const generated = await generateDocsWithDeno(packageName, version)
-
-      if (!generated) {
-        return {
-          package: packageName,
-          version,
-          html: '',
-          toc: null,
-          breadcrumbs: null,
-          status: 'missing',
-          message: 'Docs are not available for this package. It may not have TypeScript types.',
-        } satisfies DocsResponse
-      }
-
-      return {
-        package: packageName,
-        version,
-        html: generated.html,
-        toc: generated.toc,
-        breadcrumbs: null,
-        status: 'ok',
-      } satisfies DocsResponse
-    }
-    catch (error) {
-      const message = error instanceof Error ? error.message : 'Unknown error'
-      console.error(`[docs] Error generating docs for ${packageName}@${version}:`, message)
+    const generated = await generateDocsWithDeno(packageName, version)
 
+    if (!generated) {
       return {
         package: packageName,
         version,
         html: '',
         toc: null,
-        breadcrumbs: null,
-        status: 'error',
-        message: 'Failed to generate docs. The package may not export TypeScript types.',
+        status: 'missing',
+        message: 'Docs are not available for this package. It may not have TypeScript types.',
       } satisfies DocsResponse
     }
+
+    return {
+      package: packageName,
+      version,
+      html: generated.html,
+      toc: generated.toc,
+      status: 'ok',
+    } satisfies DocsResponse
   },
   {
     maxAge: 60 * 60, // 1 hour cache