Skip to content

Commit f1a354d

Browse files
committed
Remove redundant labels for banner/contentinfo landmarks
- There should only be one of each of these per document. - Any `<header>` or `<footer>` element that’s scoped to the `<main>` element or sectioning content element will not have the corresponding landmark role, so you don’t need to stop using them because they do not cause conflicts with the ones with the implicit landmark roles. - Thus, the labels are completely unnecessary and not expected.
1 parent c39683a commit f1a354d

8 files changed

Lines changed: 1 addition & 12 deletions

File tree

app/components/AppFooter.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<template>
2-
<footer class="border-t border-border mt-auto" :aria-label="$t('footer.site_footer')">
2+
<footer class="border-t border-border mt-auto">
33
<div class="container py-3 sm:py-8 flex flex-col gap-2 sm:gap-4 text-fg-subtle text-sm">
44
<div class="flex flex-col sm:flex-row items-center justify-between gap-2 sm:gap-4">
55
<p class="font-mono m-0 hidden sm:block">{{ $t('tagline') }}</p>

app/components/AppHeader.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ onKeyStroke(',', e => {
5151

5252
<template>
5353
<header
54-
:aria-label="$t('header.site_header')"
5554
class="sticky top-0 z-50 bg-bg/80 backdrop-blur-md border-b border-border"
5655
>
5756
<nav :aria-label="$t('nav.main_navigation')" class="container h-14 flex items-center">

i18n/locales/de-DE.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"non_affiliation_disclaimer": "nicht verbunden mit npm, Inc.",
1010
"trademark_disclaimer": "npm ist eine eingetragene Marke von npm, Inc. Diese Seite ist nicht mit npm, Inc. verbunden.",
1111
"footer": {
12-
"site_footer": "Fusszeile",
1312
"about": "über uns",
1413
"docs": "Doku",
1514
"source": "Quellcode",
@@ -594,7 +593,6 @@
594593
}
595594
},
596595
"header": {
597-
"site_header": "Seitenkopf",
598596
"home": "npmx Startseite",
599597
"github": "GitHub",
600598
"packages": "Pakete",

i18n/locales/en.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"non_affiliation_disclaimer": "not affiliated with npm, Inc.",
1010
"trademark_disclaimer": "npm is a registered trademark of npm, Inc. This site is not affiliated with npm, Inc.",
1111
"footer": {
12-
"site_footer": "Site footer",
1312
"about": "about",
1413
"docs": "docs",
1514
"source": "source",
@@ -598,7 +597,6 @@
598597
}
599598
},
600599
"header": {
601-
"site_header": "Site header",
602600
"home": "npmx home",
603601
"github": "GitHub",
604602
"packages": "packages",

i18n/locales/ja-JP.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"non_affiliation_disclaimer": "npm, Inc.とは関係ありません。",
1010
"trademark_disclaimer": "npmはnpm, Inc.の登録商標です。当サイトはnpm, Inc.とは関係ありません。",
1111
"footer": {
12-
"site_footer": "サイトフッター",
1312
"about": "npmxについて",
1413
"docs": "ドキュメント",
1514
"source": "ソースコード",

lunaria/files/de-DE.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"non_affiliation_disclaimer": "nicht verbunden mit npm, Inc.",
1010
"trademark_disclaimer": "npm ist eine eingetragene Marke von npm, Inc. Diese Seite ist nicht mit npm, Inc. verbunden.",
1111
"footer": {
12-
"site_footer": "Fusszeile",
1312
"about": "über uns",
1413
"docs": "Doku",
1514
"source": "Quellcode",
@@ -594,7 +593,6 @@
594593
}
595594
},
596595
"header": {
597-
"site_header": "Seitenkopf",
598596
"home": "npmx Startseite",
599597
"github": "GitHub",
600598
"packages": "Pakete",

lunaria/files/en-US.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"non_affiliation_disclaimer": "not affiliated with npm, Inc.",
1010
"trademark_disclaimer": "npm is a registered trademark of npm, Inc. This site is not affiliated with npm, Inc.",
1111
"footer": {
12-
"site_footer": "Site footer",
1312
"about": "about",
1413
"docs": "docs",
1514
"source": "source",
@@ -598,7 +597,6 @@
598597
}
599598
},
600599
"header": {
601-
"site_header": "Site header",
602600
"home": "npmx home",
603601
"github": "GitHub",
604602
"packages": "packages",

lunaria/files/ja-JP.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"non_affiliation_disclaimer": "npm, Inc.とは関係ありません。",
1010
"trademark_disclaimer": "npmはnpm, Inc.の登録商標です。当サイトはnpm, Inc.とは関係ありません。",
1111
"footer": {
12-
"site_footer": "サイトフッター",
1312
"about": "npmxについて",
1413
"docs": "ドキュメント",
1514
"source": "ソースコード",

0 commit comments

Comments
 (0)