fix: gracefully handle Algolia fetch failures

Author: serhalp

server/api/picks.get.ts

@@ -38,26 +38,32 @@ export default defineCachedEventHandler(
     const { appId, apiKey, indexName } = useRuntimeConfig().public.algolia
 
     // 1. Fetch popular packages from Algolia
-    const algoliaResponse = await $fetch<AlgoliaResponse>(
-      `https://${appId}-dsn.algolia.net/1/indexes/${indexName}/query`,
-      {
-        method: 'POST',
-        headers: {
-          'X-Algolia-Application-Id': appId,
-          'X-Algolia-API-Key': apiKey,
+    let algoliaHits: AlgoliaHit[] = []
+    try {
+      const algoliaResponse = await $fetch<AlgoliaResponse>(
+        `https://${appId}-dsn.algolia.net/1/indexes/${indexName}/query`,
+        {
+          method: 'POST',
+          headers: {
+            'X-Algolia-Application-Id': appId,
+            'X-Algolia-API-Key': apiKey,
+          },
+          body: {
+            query: '',
+            hitsPerPage: ALGOLIA_POOL_SIZE,
+            attributesToRetrieve: ['name', 'downloadsLast30Days', 'isDeprecated'],
+            attributesToHighlight: [],
+          },
         },
-        body: {
-          query: '',
-          hitsPerPage: ALGOLIA_POOL_SIZE,
-          attributesToRetrieve: ['name', 'downloadsLast30Days', 'modified', 'isDeprecated'],
-          attributesToHighlight: [],
-        },
-      },
-    )
+      )
+      algoliaHits = algoliaResponse.hits ?? []
+    } catch (error) {
+      console.warn('[picks] Algolia fetch failed, falling back to empty pool', error)
+      algoliaHits = []
+    }
 
     // 2. Post-filter pool
-    const now = Date.now()
-    const pool = algoliaResponse.hits.filter(hit => {
+    const pool = algoliaHits.filter(hit => {
       if (hit.isDeprecated) return false
       if (hit.downloadsLast30Days < MIN_DOWNLOADS_LAST_30_DAYS) return false
       return true

test/unit/server/utils/picks.spec.ts

@@ -29,10 +29,11 @@ describe('selectPicks', () => {
     }
     const picks = selectPicks(candidates)
 
-    expect(picks[0]!.letterIndex).toBe('next'.indexOf('n'))
-    expect(picks[1]!.letterIndex).toBe('webpack'.indexOf('p'))
-    expect(picks[2]!.letterIndex).toBe('commander'.indexOf('m'))
-    expect(picks[3]!.letterIndex).toBe('luxon'.indexOf('x'))
+    expect(picks).toHaveLength(4)
+    expect(picks[0]?.letterIndex).toBe('next'.indexOf('n'))
+    expect(picks[1]?.letterIndex).toBe('webpack'.indexOf('p'))
+    expect(picks[2]?.letterIndex).toBe('commander'.indexOf('m'))
+    expect(picks[3]?.letterIndex).toBe('luxon'.indexOf('x'))
   })
 
   it('prefers liked candidates over non-liked', () => {
@@ -61,24 +62,41 @@ describe('selectPicks', () => {
       x: [{ name: 'luxon', totalLikes: 0 }],
     }
     const picks = selectPicks(candidates)
-    expect(picks[0]!.name).toBe('nodemon')
-    expect(picks[1]!.name).toBe('prettier')
-    expect(picks[2]!.name).toBe('mocha')
-    expect(picks[3]!.name).toBe('luxon')
+    expect(picks).toHaveLength(4)
+    expect(picks[0]?.name).toBe('nodemon')
+    expect(picks[1]?.name).toBe('prettier')
+    expect(picks[2]?.name).toBe('mocha')
+    expect(picks[3]?.name).toBe('luxon')
   })
 
-  it('falls back to hardcoded when no candidates at all', () => {
+  it('falls back to hardcoded fallbacks when no candidates at all', () => {
     const candidates: Record<NpmxLetter, PickCandidate[]> = {
       n: [],
       p: [],
       m: [],
       x: [],
     }
     const picks = selectPicks(candidates)
-    expect(picks[0]!.name).toBe(FALLBACKS.n)
-    expect(picks[1]!.name).toBe(FALLBACKS.p)
-    expect(picks[2]!.name).toBe(FALLBACKS.m)
-    expect(picks[3]!.name).toBe(FALLBACKS.x)
+    expect(picks).toHaveLength(4)
+    expect(picks[0]?.name).toBe(FALLBACKS.n)
+    expect(picks[1]?.name).toBe(FALLBACKS.p)
+    expect(picks[2]?.name).toBe(FALLBACKS.m)
+    expect(picks[3]?.name).toBe(FALLBACKS.x)
+  })
+
+  it('falls back to hardcoded fallbacks when the request to Algolia fails', () => {
+    const candidates: Record<NpmxLetter, PickCandidate[]> = {
+      n: [],
+      p: [],
+      m: [],
+      x: [],
+    }
+    const picks = selectPicks(candidates)
+    expect(picks).toHaveLength(4)
+    expect(picks[0]?.name).toBe(FALLBACKS.n)
+    expect(picks[1]?.name).toBe(FALLBACKS.p)
+    expect(picks[2]?.name).toBe(FALLBACKS.m)
+    expect(picks[3]?.name).toBe(FALLBACKS.x)
   })
 
   it('does not duplicate packages across picks', () => {