Skip to content

Commit f378ff6

Browse files
committed
Apply suggestion from Coderabbit
1 parent b4ec00c commit f378ff6

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

app/utils/install-command.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,12 +140,12 @@ function hasReadmeDevInstallHint(packageName: string, readmeHtml?: string | null
140140
const patterns = [
141141
// npm install -D pkg / pnpm add --save-dev pkg
142142
new RegExp(
143-
String.raw`(?:npm|pnpm|yarn|bun|vlt)\s+(?:install|add|i)\s+(?:--save-dev|-d)\s+${packageSpec}`,
143+
String.raw`(?:npm|pnpm|yarn|bun|vlt)\s+(?:install|add|i)\s+(?:--save-dev|--dev|-d)\s+${packageSpec}`,
144144
'i',
145145
),
146146
// npm install pkg --save-dev / pnpm add pkg -D
147147
new RegExp(
148-
String.raw`(?:npm|pnpm|yarn|bun|vlt)\s+(?:install|add|i)\s+${packageSpec}\s+(?:--save-dev|-d)`,
148+
String.raw`(?:npm|pnpm|yarn|bun|vlt)\s+(?:install|add|i)\s+${packageSpec}\s+(?:--save-dev|--dev|-d)`,
149149
'i',
150150
),
151151
// deno add -D npm:pkg

test/unit/app/utils/install-command.spec.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -310,6 +310,15 @@ describe('install command generation', () => {
310310
})
311311
})
312312

313+
it('suggests dev dependency from README --dev flag hints', () => {
314+
const readmeHtml = '<p><code>yarn add --dev some-tool</code></p>'
315+
316+
expect(getDevDependencySuggestion('some-tool', readmeHtml)).toEqual({
317+
recommended: true,
318+
reason: 'readme-hint',
319+
})
320+
})
321+
313322
it('does not suggest dev dependency for runtime packages without hints', () => {
314323
expect(getDevDependencySuggestion('react')).toEqual({
315324
recommended: false,

0 commit comments

Comments
 (0)