Skip to content

Commit f44bec6

Browse files
authored
do test differently
1 parent f6838c5 commit f44bec6

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

test/e2e/compare-replacements.spec.ts

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ test.describe('Compare page - replacement suggestions', () => {
55
page,
66
goto,
77
}) => {
8-
// is-odd has a 'simple' replacement in module-replacements v3
98
await goto('/compare?packages=is-odd,is-even', { waitUntil: 'hydration' })
109

11-
// The suggestion box should appear after client-side fetch resolves
12-
// Button text comes from $t('package.replacement.consider_no_dep')
13-
const considerNoDepButton = page.getByRole('button', { name: /consider no dep/i })
14-
await expect(considerNoDepButton).toBeVisible({ timeout: 15_000 })
10+
const considerNoDepButton = await page.waitForSelector('button[aria-label="Add no dependency column to comparison"]', {
11+
timeout: 15_000
12+
})
13+
14+
expect(considerNoDepButton).not.toBeNull()
1515
})
1616

1717
test('does not show "Consider no dep?" box for packages without replacements', async ({
@@ -20,7 +20,10 @@ test.describe('Compare page - replacement suggestions', () => {
2020
}) => {
2121
await goto('/compare?packages=nuxt,vue', { waitUntil: 'hydration' })
2222

23-
const considerNoDepButton = page.getByRole('button', { name: /consider no dep/i })
24-
await expect(considerNoDepButton).not.toBeVisible({ timeout: 10_000 })
23+
await page.waitForTimeout(10000)
24+
25+
const considerNoDepButton = await page.querySelector('button[aria-label="Add no dependency column to comparison"]')
26+
27+
expect(considerNoDepButton).toBeNull()
2528
})
2629
})

0 commit comments

Comments
 (0)