Skip to content

Commit f4510e6

Browse files
committed
chore: feedback enhancements
1 parent 5e00104 commit f4510e6

3 files changed

Lines changed: 5 additions & 2 deletions

File tree

CONTRIBUTING.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,9 @@ Configure dev server to run at `http://npmx.test:3000` instead of `http://127.0.
105105
# 1. Install Localias
106106
brew install peterldowns/tap/localias
107107

108+
# Linux/WSL2
109+
go install github.com/peterldowns/localias/cmd/localias@latest
110+
108111
# 2. Run setup (requires sudo)
109112
pnpm setup:local
110113

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"generate:fixtures": "node scripts/generate-fixtures.ts",
3636
"generate:lexicons": "lex build --lexicons lexicons --out shared/types/lexicons --clear",
3737
"setup:local": "bash scripts/setup-local-domain.sh",
38-
"setup:local:uninstall": "localias rm npmx.test && sudo localias stop || echo 'No local domain configured'",
38+
"setup:local:uninstall": "bash -c 'if localias rm npmx.test; then sudo localias stop || echo \"Failed to stop Localias daemon\"; else echo \"No local domain configured\"; fi'",
3939
"test": "vite test",
4040
"test:a11y": "pnpm build:test && LIGHTHOUSE_COLOR_MODE=dark pnpm test:a11y:prebuilt && LIGHTHOUSE_COLOR_MODE=light pnpm test:a11y:prebuilt",
4141
"test:a11y:prebuilt": "./scripts/lighthouse.sh",

scripts/setup-local-domain.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ fi
8888
# Start daemon
8989
echo "Starting localias daemon (requires sudo)..."
9090
sudo localias stop 2>/dev/null || true
91-
if ! sudo localias start 2>&1 | grep -q "server running"; then
91+
if ! sudo localias start; then
9292
error_exit "Failed to start daemon" "Check ports 80/443 or run: sudo localias start"
9393
fi
9494

0 commit comments

Comments
 (0)