Skip to content

Commit f4f1ce9

Browse files
committed
wip
fix: pass reactive getter to usePackage for version reactivity on client-side navigation
1 parent 788a963 commit f4f1ce9

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

app/components/diff/ViewerPanel.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<script setup lang="ts">
22
import type { FileDiffResponse, FileChange, DiffHunk } from '#shared/types'
33
import { createDiff, insertSkipBlocks, countDiffStats } from '#shared/utils/diff'
4-
// @ts-expect-error: (tasky): idk why this is type-erroring even if it has types? /shrug
54
import { motion } from 'motion-v'
65
76
const props = defineProps<{

app/pages/diff/[...path].vue

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,12 @@ const toVersionUrlPattern = computed(() => {
111111
112112
function packageRoute(ver?: string | null) {
113113
const segments = packageName.value.split('/')
114-
if (ver) segments.push('v', ver)
115-
return { name: 'package' as const, params: { package: segments } }
114+
const org = segments.length > 1 ? segments[0] : undefined
115+
const name = segments.length > 1 ? segments[1]! : segments[0]!
116+
if (ver) {
117+
return { name: 'package-version' as const, params: { org, name, version: ver } }
118+
}
119+
return { name: 'package' as const, params: { org, name } }
116120
}
117121
118122
useSeoMeta({

app/pages/package/[[org]]/[name].vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ const {
142142
data: pkg,
143143
status,
144144
error,
145-
} = usePackage(packageName, resolvedVersion.value ?? requestedVersion.value)
145+
} = usePackage(packageName, () => resolvedVersion.value ?? requestedVersion.value)
146146
const displayVersion = computed(() => pkg.value?.requestedVersion ?? null)
147147
148148
// Process package description

0 commit comments

Comments
 (0)