fix: throw 404 statusCode instead of 400

Author: danielroe

app/pages/[...package].vue

@@ -1,10 +1,10 @@
 <script setup lang="ts">
 import type { NpmVersionDist, PackumentVersion, ReadmeResponse } from '#shared/types'
 import type { JsrPackageInfo } from '#shared/types/jsr'
+import { assertValidPackageName } from '#shared/utils/npm'
 import { onKeyStroke } from '@vueuse/core'
 import { joinURL } from 'ufo'
 import { areUrlsEquivalent } from '#shared/utils/url'
-import validatePackageName from 'validate-npm-package-name'
 
 definePageMeta({
   name: 'package',
@@ -17,18 +17,8 @@ const { packageName, requestedVersion, orgName } = usePackageRoute()
 const selectedPM = useSelectedPackageManager()
 const activePmId = computed(() => selectedPM.value ?? 'npm')
 
-// Validate package name on server and show proper error page if invalid
 if (import.meta.server) {
-  const validation = validatePackageName(packageName.value)
-  if (!validation.validForNewPackages && !validation.validForOldPackages) {
-    const errorMessage =
-      validation.errors?.[0] ?? validation.warnings?.[0] ?? 'Invalid package name'
-    showError({
-      statusCode: 400,
-      statusMessage: 'Invalid Package Name',
-      message: errorMessage,
-    })
-  }
+  assertValidPackageName(packageName.value)
 }
 
 const { data: downloads } = usePackageDownloads(packageName, 'last-week')

server/api/registry/badge/[...pkg].get.ts

@@ -14,7 +14,8 @@ export default defineCachedEventHandler(
   async event => {
     const pkgParamSegments = getRouterParam(event, 'pkg')?.split('/') ?? []
     if (pkgParamSegments.length === 0) {
-      throw createError({ statusCode: 400, message: 'Package name is required.' })
+      // TODO: throwing 404 rather than 400 as it's cacheable
+      throw createError({ statusCode: 404, message: 'Package name is required.' })
     }
 
     const { rawPackageName, rawVersion } = parsePackageParams(pkgParamSegments)

server/api/registry/docs/[...pkg].get.ts

@@ -8,13 +8,15 @@ export default defineCachedEventHandler(
   async event => {
     const pkgParam = getRouterParam(event, 'pkg')
     if (!pkgParam) {
-      throw createError({ statusCode: 400, message: 'Package name is required' })
+      // TODO: throwing 404 rather than 400 as it's cacheable
+      throw createError({ statusCode: 404, message: 'Package name is required' })
     }
 
     const { packageName, version: requestedVersion } = parsePackageParam(pkgParam)
 
     if (!packageName) {
-      throw createError({ statusCode: 400, message: 'Package name is required' })
+      // TODO: throwing 404 rather than 400 as it's cacheable
+      throw createError({ statusCode: 404, message: 'Package name is required' })
     }
     assertValidPackageName(packageName)
 

server/api/registry/file/[...pkg].get.ts

@@ -106,7 +106,8 @@ export default defineCachedEventHandler(
 
     if (versionSegments.length < 2) {
       throw createError({
-        statusCode: 400,
+        // TODO: throwing 404 rather than 400 as it's cacheable
+        statusCode: 404,
         message: ERROR_PACKAGE_VERSION_AND_FILE_FAILED,
       })
     }

server/api/registry/org/[org]/packages.get.ts

@@ -8,7 +8,8 @@ const NPM_ORG_NAME_RE = /^[a-z0-9]([a-z0-9-]*[a-z0-9])?$/i
 function validateOrgName(name: string): void {
   if (!name || name.length > 50 || !NPM_ORG_NAME_RE.test(name)) {
     throw createError({
-      statusCode: 400,
+      // TODO: throwing 404 rather than 400 as it's cacheable
+      statusCode: 404,
       message: `Invalid org name: ${name}`,
     })
   }
@@ -20,7 +21,8 @@ export default defineCachedEventHandler(
 
     if (!org) {
       throw createError({
-        statusCode: 400,
+        // TODO: throwing 404 rather than 400 as it's cacheable
+        statusCode: 404,
         message: 'Org name is required',
       })
     }

server/utils/error-handler.ts

@@ -16,7 +16,8 @@ export function handleApiError(error: unknown, fallback: ErrorOptions): never {
   // Handle Valibot validation errors
   if (v.isValiError(error)) {
     throw createError({
-      statusCode: 400,
+      // TODO: throwing 404 rather than 400 as it's cacheable
+      statusCode: 404,
       message: error.issues[0].message,
     })
   }

shared/utils/npm.ts

@@ -10,7 +10,8 @@ export function assertValidPackageName(name: string): void {
   if (!result.validForNewPackages && !result.validForOldPackages) {
     const errors = [...(result.errors ?? []), ...(result.warnings ?? [])]
     throw createError({
-      statusCode: 400,
+      // TODO: throwing 404 rather than 400 as it's cacheable
+      statusCode: 404,
       message: `Invalid package name: ${errors[0] ?? 'unknown error'}`,
     })
   }