fix: address CodeRabbit review comments

- Add index clamping in generateSparkline() to prevent floating-point edge cases
- Update getRepositoryUrl() to handle string repository values (common in npm metadata)
- Add unit tests for string repository handling

Author: BYK

server/utils/markdown.ts

@@ -20,7 +20,9 @@ export function generateSparkline(data: number[]): string {
   return data
     .map(val => {
       const normalized = (val - min) / range
-      const index = Math.round(normalized * (SPARKLINE_CHARS.length - 1))
+      // Clamp index to valid bounds to prevent floating-point edge cases
+      const rawIndex = Math.round(normalized * (SPARKLINE_CHARS.length - 1))
+      const index = Math.min(SPARKLINE_CHARS.length - 1, Math.max(0, rawIndex))
       return SPARKLINE_CHARS[index]
     })
     .join('')
@@ -64,17 +66,24 @@ function isHttpUrl(url: string): boolean {
   }
 }
 
-function getRepositoryUrl(repository?: {
-  type?: string
-  url?: string
-  directory?: string
-}): string | null {
-  if (!repository?.url) return null
-  let url = normalizeGitUrl(repository.url)
+function getRepositoryUrl(
+  repository?:
+    | {
+        type?: string
+        url?: string
+        directory?: string
+      }
+    | string,
+): string | null {
+  if (!repository) return null
+  // Handle both string and object forms of repository field
+  const repoUrl = typeof repository === 'string' ? repository : repository.url
+  if (!repoUrl) return null
+  let url = normalizeGitUrl(repoUrl)
   // Skip non-HTTP URLs after normalization
   if (!isHttpUrl(url)) return null
-  // Append directory for monorepo packages
-  if (repository.directory) {
+  // Append directory for monorepo packages (only available in object form)
+  if (typeof repository !== 'string' && repository.directory) {
     url = joinURL(`${url}/tree/HEAD`, repository.directory)
   }
   return url

test/unit/server/utils/markdown.spec.ts

@@ -179,6 +179,40 @@ describe('markdown utils', () => {
       )
     })
 
+    it('handles string repository URL', () => {
+      const pkg = createMockPkg({
+        repository: 'https://github.com/user/repo' as any,
+      })
+      const version = createMockVersion()
+
+      const result = generatePackageMarkdown({ pkg, version })
+
+      expect(result).toContain('- [Repository](https://github.com/user/repo)')
+    })
+
+    it('normalizes string repository with git+ prefix', () => {
+      const pkg = createMockPkg({
+        repository: 'git+https://github.com/user/repo.git' as any,
+      })
+      const version = createMockVersion()
+
+      const result = generatePackageMarkdown({ pkg, version })
+
+      expect(result).toContain('- [Repository](https://github.com/user/repo)')
+    })
+
+    it('handles GitHub shorthand string repository', () => {
+      const pkg = createMockPkg({
+        repository: 'github:user/repo' as any,
+      })
+      const version = createMockVersion()
+
+      const result = generatePackageMarkdown({ pkg, version })
+
+      // github: shorthand is not a valid HTTP URL, so should be skipped
+      expect(result).not.toContain('- [Repository]')
+    })
+
     it('includes homepage link when different from repo', () => {
       const pkg = createMockPkg({
         repository: { url: 'https://github.com/user/repo' },