fix: fix kB/KiB confusion (#1541)

Author: wojtekmaj

app/composables/useNumberFormatter.ts

@@ -16,19 +16,21 @@ export const useBytesFormatter = () => {
   const decimalNumberFormatter = useNumberFormatter({
     maximumFractionDigits: 1,
   })
+  const KB = 1000
+  const MB = 1000 * 1000
 
   return {
     format: (bytes: number) => {
-      if (bytes < 1024)
+      if (bytes < KB)
         return t('package.size.b', {
           size: decimalNumberFormatter.value.format(bytes),
         })
-      if (bytes < 1024 * 1024)
+      if (bytes < MB)
         return t('package.size.kb', {
-          size: decimalNumberFormatter.value.format(bytes / 1024),
+          size: decimalNumberFormatter.value.format(bytes / KB),
         })
       return t('package.size.mb', {
-        size: decimalNumberFormatter.value.format(bytes / (1024 * 1024)),
+        size: decimalNumberFormatter.value.format(bytes / MB),
       })
     },
   }

test/unit/app/composables/use-number-formatter.spec.ts

@@ -0,0 +1,46 @@
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+import { computed, ref } from 'vue'
+import { useBytesFormatter } from '../../../../app/composables/useNumberFormatter'
+
+describe('useBytesFormatter', () => {
+  beforeEach(() => {
+    vi.stubGlobal('computed', computed)
+    vi.stubGlobal('useI18n', () => ({
+      locale: ref('en-US'),
+      t: (key: string, params?: { size?: string }) => {
+        const size = params?.size ?? ''
+
+        if (key === 'package.size.b') return `${size} B`
+        if (key === 'package.size.kb') return `${size} kB`
+        if (key === 'package.size.mb') return `${size} MB`
+
+        return key
+      },
+    }))
+  })
+
+  afterEach(() => {
+    vi.unstubAllGlobals()
+  })
+
+  it('formats values below 1 kB in bytes', () => {
+    const { format } = useBytesFormatter()
+
+    expect(format(0)).toBe('0 B')
+    expect(format(999)).toBe('999 B')
+  })
+
+  it('formats kB values using decimal base (1000)', () => {
+    const { format } = useBytesFormatter()
+
+    expect(format(1000)).toBe('1 kB')
+    expect(format(8414)).toBe('8.4 kB')
+  })
+
+  it('formats MB values using decimal base (1000 * 1000)', () => {
+    const { format } = useBytesFormatter()
+
+    expect(format(1_000_000)).toBe('1 MB')
+    expect(format(1_500_000)).toBe('1.5 MB')
+  })
+})