removing target when url doesn't have protocol (for example when pointing to an id)

WilcoSp · WilcoSp · commit fcacad887474 · 2026-03-16T18:31:46.000+01:00
diff --git a/server/utils/changelog/markdown.ts b/server/utils/changelog/markdown.ts
@@ -205,6 +205,8 @@ export function sanitizeRawHTML(
         if (resolvedHref && hasProtocol(resolvedHref, { acceptRelative: true })) {
           attribs.rel = 'nofollow noreferrer noopener'
           attribs.target = '_blank'
+        } else {
+          attribs.target = ''
         }
         attribs.href = resolvedHref
         return { tagName, attribs }
@@ -236,7 +238,7 @@ function resolveUrl(url: string, repoInfo: MarkdownRepoInfo, idPrefix: string) {
       return url
     }
     // Prefix anchor links to match heading IDs (avoids collision with page IDs)
-    return `#${idPrefix}-${url.slice(1)}`
+    return `#${idPrefix}-${slugify(url.slice(1))}`
   }
   if (hasProtocol(url, { acceptRelative: true })) {
     try {

Original file line number	Diff line number	Diff line change
`@@ -205,6 +205,8 @@ export function sanitizeRawHTML(`
`205`	`205`	`if (resolvedHref && hasProtocol(resolvedHref, { acceptRelative: true })) {`
`206`	`206`	`attribs.rel = 'nofollow noreferrer noopener'`
`207`	`207`	`attribs.target = '_blank'`
	`208`	`+ } else {`
	`209`	`+ attribs.target = ''`
`208`	`210`	`}`
`209`	`211`	`attribs.href = resolvedHref`
`210`	`212`	`return { tagName, attribs }`
`@@ -236,7 +238,7 @@ function resolveUrl(url: string, repoInfo: MarkdownRepoInfo, idPrefix: string) {`
`236`	`238`	`return url`
`237`	`239`	`}`
`238`	`240`	`// Prefix anchor links to match heading IDs (avoids collision with page IDs)`
`239`		- return `#${idPrefix}-${url.slice(1)}`
	`241`	+ return `#${idPrefix}-${slugify(url.slice(1))}`
`240`	`242`	`}`
`241`	`243`	`if (hasProtocol(url, { acceptRelative: true })) {`
`242`	`244`	`try {`