cr

Author: eryue0220

app/components/Package/DeprecatePackageModal.vue

@@ -9,8 +9,10 @@ const props = withDefaults(
   defineProps<{
     packageName: string
     version?: string
+    /** When true, the package or version is already deprecated; form is hidden and state cannot be changed. */
+    isAlreadyDeprecated?: boolean
   }>(),
-  { version: '' },
+  { version: '', isAlreadyDeprecated: false },
 )
 
 const { t } = useI18n()
@@ -32,6 +34,7 @@ const modalTitle = computed(() =>
 )
 
 async function handleDeprecate() {
+  if (props.isAlreadyDeprecated) return
   const message = deprecateMessage.value.trim()
   if (!isConnected.value) return
 
@@ -119,8 +122,32 @@ defineExpose({ open, close })
 
 <template>
   <Modal ref="dialogRef" :modal-title="modalTitle" id="deprecate-package-modal" class="max-w-md">
+    <!-- Already deprecated: read-only, no form -->
+    <div v-if="isAlreadyDeprecated" class="space-y-4">
+      <div
+        class="flex items-center gap-3 p-4 bg-amber-500/10 border border-amber-500/20 rounded-lg"
+      >
+        <span class="i-carbon-warning-alt text-amber-500 w-6 h-6" aria-hidden="true" />
+        <div>
+          <p class="font-mono text-sm text-fg">
+            {{ $t('package.deprecation.modal.already_deprecated') }}
+          </p>
+          <p class="text-xs text-fg-muted">
+            {{ $t('package.deprecation.modal.already_deprecated_detail') }}
+          </p>
+        </div>
+      </div>
+      <button
+        type="button"
+        class="w-full px-4 py-2 font-mono text-sm text-fg-muted bg-bg-subtle border border-border rounded-md transition-colors duration-200 hover:text-fg hover:border-border-hover focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-fg/50"
+        @click="close"
+      >
+        {{ $t('common.close') }}
+      </button>
+    </div>
+
     <!-- Success state -->
-    <div v-if="deprecateSuccess" class="space-y-4">
+    <div v-else-if="deprecateSuccess" class="space-y-4">
       <div
         class="flex items-center gap-3 p-4 bg-green-500/10 border border-green-500/20 rounded-lg"
       >
@@ -141,7 +168,7 @@ defineExpose({ open, close })
       </button>
     </div>
 
-    <!-- Form (only shown when connected; parent only opens modal when isConnected) -->
+    <!-- Form (only shown when not already deprecated and connected) -->
     <div v-else class="space-y-4">
       <div>
         <label for="deprecate-message" class="block text-sm font-medium text-fg mb-1">

app/pages/package/[[org]]/[name].vue

@@ -204,6 +204,13 @@ const latestVersion = computed(() => {
   return pkg.value.versions[latestTag] ?? null
 })
 
+/** True when the currently displayed version (or resolved version) is deprecated; used to hide deprecate button. */
+const isCurrentVersionDeprecated = computed(() => {
+  if (displayVersion.value?.deprecated) return true
+  const ver = resolvedVersion.value
+  return !!(ver && pkg.value?.versions?.[ver]?.deprecated)
+})
+
 const deprecationNotice = computed(() => {
   if (!displayVersion.value?.deprecated) return null
 
@@ -1202,19 +1209,18 @@ onKeyStroke(
           <!-- Maintainers (with admin actions when connected) -->
           <PackageMaintainers :package-name="pkg.name" :maintainers="pkg.maintainers" />
 
-          <!-- Deprecation (when connected as package owner) -->
-          <div v-if="isConnected && resolvedVersion && isPackageOwner" class="space-y-1">
+          <!-- Deprecation (when connected as package owner; hidden when current version is already deprecated) -->
+          <div
+            v-if="isConnected && resolvedVersion && isPackageOwner && !isCurrentVersionDeprecated"
+            class="space-y-1"
+          >
             <button
               type="button"
               class="flex items-center justify-center w-full px-3 py-1.5 bg-bg-subtle rounded text-sm font-mono text-red-400 hover:text-red-500 transition-colors inline-flex items-center gap-1.5 w-full"
               @click="deprecateModal?.open()"
             >
               <span class="i-carbon-warning-alt w-4 h-4 shrink-0" aria-hidden="true" />
-              {{
-                deprecationNotice
-                  ? $t('package.deprecation.action_change')
-                  : $t('package.deprecation.action')
-              }}
+              {{ $t('package.deprecation.action') }}
             </button>
           </div>
         </div>
@@ -1243,6 +1249,7 @@ onKeyStroke(
         ref="deprecateModal"
         :package-name="pkg.name"
         :version="resolvedVersion ?? ''"
+        :is-already-deprecated="isCurrentVersionDeprecated"
       />
     </ClientOnly>
   </main>

i18n/locales/en.json

@@ -122,7 +122,6 @@
     "copy_name": "Copy package name",
     "deprecation": {
       "action": "Deprecate",
-      "action_change": "Change deprecation",
       "package": "This package has been deprecated.",
       "version": "This version has been deprecated.",
       "no_reason": "No reason provided",
@@ -135,7 +134,9 @@
         "success": "Package deprecated",
         "success_detail": "The package has been deprecated.",
         "version": "Version",
-        "version_placeholder": "Leave empty to deprecate the whole package"
+        "version_placeholder": "Leave empty to deprecate the whole package",
+        "already_deprecated": "Already deprecated",
+        "already_deprecated_detail": "This package or version is already deprecated. Deprecation status cannot be changed."
       }
     },
     "replacement": {

i18n/locales/zh-CN.json

@@ -122,7 +122,6 @@
     "copy_name": "复制包名",
     "deprecation": {
       "action": "废弃",
-      "action_change": "修改弃用",
       "package": "这个包已经被弃用。",
       "version": "这个版本已经被弃用。",
       "no_reason": "没有提供原因",
@@ -135,7 +134,9 @@
         "success": "包已废弃",
         "success_detail": "这个包已废弃。",
         "version": "版本",
-        "version_placeholder": "留空则废弃整个包"
+        "version_placeholder": "留空则废弃整个包",
+        "already_deprecated": "已废弃",
+        "already_deprecated_detail": "该包或版本已处于废弃状态，无法再修改废弃状态。"
       }
     },
     "replacement": {

lunaria/files/en-GB.json

@@ -122,7 +122,6 @@
     "copy_name": "Copy package name",
     "deprecation": {
       "action": "Deprecate",
-      "action_change": "Change deprecation",
       "package": "This package has been deprecated.",
       "version": "This version has been deprecated.",
       "no_reason": "No reason provided",
@@ -135,7 +134,9 @@
         "success": "Package deprecated",
         "success_detail": "The package has been deprecated.",
         "version": "Version",
-        "version_placeholder": "Leave empty to deprecate the whole package"
+        "version_placeholder": "Leave empty to deprecate the whole package",
+        "already_deprecated": "Already deprecated",
+        "already_deprecated_detail": "This package or version is already deprecated. Deprecation status cannot be changed."
       }
     },
     "replacement": {

lunaria/files/en-US.json

@@ -122,7 +122,6 @@
     "copy_name": "Copy package name",
     "deprecation": {
       "action": "Deprecate",
-      "action_change": "Change deprecation",
       "package": "This package has been deprecated.",
       "version": "This version has been deprecated.",
       "no_reason": "No reason provided",
@@ -135,7 +134,9 @@
         "success": "Package deprecated",
         "success_detail": "The package has been deprecated.",
         "version": "Version",
-        "version_placeholder": "Leave empty to deprecate the whole package"
+        "version_placeholder": "Leave empty to deprecate the whole package",
+        "already_deprecated": "Already deprecated",
+        "already_deprecated_detail": "This package or version is already deprecated. Deprecation status cannot be changed."
       }
     },
     "replacement": {

lunaria/files/zh-CN.json

@@ -122,7 +122,6 @@
     "copy_name": "复制包名",
     "deprecation": {
       "action": "废弃",
-      "action_change": "修改弃用",
       "package": "这个包已经被弃用。",
       "version": "这个版本已经被弃用。",
       "no_reason": "没有提供原因",
@@ -135,7 +134,9 @@
         "success": "包已废弃",
         "success_detail": "这个包已废弃。",
         "version": "版本",
-        "version_placeholder": "留空则废弃整个包"
+        "version_placeholder": "留空则废弃整个包",
+        "already_deprecated": "已废弃",
+        "already_deprecated_detail": "该包或版本已处于废弃状态，无法再修改废弃状态。"
       }
     },
     "replacement": {

test/nuxt/components/DeprecatePackageModal.spec.ts

@@ -114,6 +114,17 @@ describe('DeprecatePackageModal', () => {
       expect(versionInput.exists()).toBe(true)
       expect((versionInput.element as HTMLInputElement).value).toBe('2.0.0')
     })
+
+    it('shows already-deprecated message and no form when isAlreadyDeprecated is true', async () => {
+      const component = await mountSuspended(DeprecatePackageModal, {
+        props: { packageName: 'my-pkg', version: '1.0.0', isAlreadyDeprecated: true },
+        ...mountOptions,
+      })
+
+      expect(component.find('#deprecate-message').exists()).toBe(false)
+      expect(component.find('#deprecate-version').exists()).toBe(false)
+      expect(component.html()).toMatch(/already deprecated|已废弃/i)
+    })
   })
 
   describe('exposed open() and close()', () => {
@@ -189,6 +200,18 @@ describe('DeprecatePackageModal', () => {
       expect(mockAddOperation).not.toHaveBeenCalled()
     })
 
+    it('handleDeprecate does nothing when isAlreadyDeprecated is true', async () => {
+      mockIsConnected.value = true
+      const component = await mountSuspended(DeprecatePackageModal, {
+        props: { packageName: 'pkg', isAlreadyDeprecated: true },
+        ...mountOptions,
+      })
+
+      await getVM(component).handleDeprecate?.()
+
+      expect(mockAddOperation).not.toHaveBeenCalled()
+    })
+
     it('handleDeprecate does nothing when message is empty', async () => {
       const component = await mountSuspended(DeprecatePackageModal, {
         props: { packageName: 'pkg' },