Skip to content

Commit fea7666

Browse files
fix: improve zero direct dependencies messaging for clarity
1 parent 220a136 commit fea7666

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

app/components/Package/ZeroDirectDependencies.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<template>
22
<section aria-labelledby="zero-direct-deps-heading" class="relative">
33
<div
4-
role="status"
54
class="border border-emerald-600/40 bg-emerald-500/10 rounded-lg px-3 py-2 text-base text-emerald-800 dark:text-emerald-400"
65
>
76
<h2 id="zero-direct-deps-heading" class="font-medium mb-1 flex items-center gap-2">

app/pages/package/[[org]]/[name].vue

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -458,8 +458,9 @@ const hasDependencies = computed(() => {
458458
459459
const hasZeroDirectDependencies = computed(
460460
() =>
461-
!displayVersion.value?.dependencies ||
462-
Object.keys(displayVersion.value.dependencies).length === 0,
461+
displayVersion.value &&
462+
(!displayVersion.value.dependencies ||
463+
Object.keys(displayVersion.value.dependencies).length === 0),
463464
)
464465
465466
// Vulnerability count for the stats banner

i18n/locales/en.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@
415415
"outdated_patch": "Patch update available (latest: {latest})",
416416
"has_replacement": "This dependency has suggested replacements",
417417
"zero_direct_banner_title": "0 direct dependencies",
418-
"zero_direct_banner_desc": "This package has no direct dependencies."
418+
"zero_direct_banner_desc": "This package can help keep node_modules smaller and reduce the risk of upcoming security issues."
419419
},
420420
"peer_dependencies": {
421421
"title": "Peer Dependency ({count}) | Peer Dependencies ({count})",

i18n/locales/zh-CN.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@
405405
"outdated_patch": "有可用的补丁更新(最新:{latest})",
406406
"has_replacement": "该依赖有推荐的替代包。",
407407
"zero_direct_banner_title": "0 个直接依赖",
408-
"zero_direct_banner_desc": "该包没有任何直接依赖"
408+
"zero_direct_banner_desc": "这个包有利于你维护更小体积的 node_modules ,并降低未来安全问题的风险"
409409
},
410410
"peer_dependencies": {
411411
"title": "对等依赖({count} 个)",

0 commit comments

Comments
 (0)