package page doesn't load with javascript disabled

[lorypelli]

It doesn't work at all without javascript and before it was working

[NandkishorJadoun]

this pr likely caused the issue because earlier the package pages did not use any fallback, so when a package page was requested for the first time, the server would wait, render the full html, and send real content that worked even with js disabled, but this pr added spa fallbacks which means that on a cache miss the server now returns an empty html and expects the browsers js to load the data and render the page later, so when js is disabled the page has nothing to render and appears blank while already cached pages still work because they already have server rendered html saved.

[lorypelli]

could it be fixed?

[danielroe]

@NandkishorJadoun is absolutely right - this is a performance improvement to avoid a long hang for initial load of a page.

and it only affects cold load - if you try, then reload a few seconds later, you should get the page just fine

our options are:

1. revert the approach (slower 'cold' load for pages which haven't yet been cached)
2. add code to reload the page automatically (via a <meta> tag within a <noscript>? would this work?)
3. accept that the edge case of hitting an uncached package page will occasionally mean pages can't be rendered without JS

I'm inclined to adopt option 2.

[lorypelli]

@NandkishorJadoun is absolutely right - this is a performance improvement to avoid a long hang for initial load of a page.

and it only affects cold load - if you try, then reload a few seconds later, you should get the page just fine

our options are:

1. revert the approach (slower 'cold' load for pages which haven't yet been cached)
2. add code to reload the page automatically (via a <meta> tag within a <noscript>? would this work?)
3. accept that the edge case of hitting an uncached package page will occasionally mean pages can't be rendered without JS

I'm inclined to adopt option 2.

Option 2 prob with <meta> I also agree