fix(config.ts): better logic for parsed env values

Author: 0xKrauser

src/commands/config.ts

@@ -48,7 +48,7 @@ export const configValidators = {
     return value;
   },
   [CONFIG_KEYS.OPENCOMMIT_DESCRIPTION](value: any) {
-    const parsedValue = typeof value === 'boolean' || value === 'true' ? value : 'false'
+    const parsedValue = typeof value === 'boolean' ? value : value === 'true' ? true : false
     validateConfig(
       CONFIG_KEYS.OPENCOMMIT_DESCRIPTION,
       typeof parsedValue === 'boolean',
@@ -58,7 +58,7 @@ export const configValidators = {
     return parsedValue;
   },
   [CONFIG_KEYS.OPENCOMMIT_EMOJI](value: any) {
-    const parsedValue = typeof value === 'boolean' || value === 'true' ? value : 'false'
+    const parsedValue = typeof value === 'boolean' ? value : value === 'true' ? true : false
     validateConfig(
       CONFIG_KEYS.OPENCOMMIT_EMOJI,
       typeof parsedValue === 'boolean',

src/generateCommitMessageFromGitDiff.ts

@@ -3,7 +3,7 @@ import {
   ChatCompletionRequestMessageRoleEnum
 } from 'openai';
 import { api } from './api';
-import { CONFIG_KEYS, getConfig } from './commands/config';
+import { getConfig } from './commands/config';
 import { mergeStrings } from './utils/mergeStrings';
 
 const config = getConfig();
@@ -12,11 +12,11 @@ const INIT_MESSAGES_PROMPT: Array<ChatCompletionRequestMessage> = [
   {
     role: ChatCompletionRequestMessageRoleEnum.System,
     content: `You are to act as the author of a commit message in git. Your mission is to create clean and comprehensive commit messages in the conventional commit convention. I'll send you an output of 'git diff --staged' command, and you convert it into a commit message. ${
-      config?.[CONFIG_KEYS.OPENCOMMIT_EMOJI]
+      config?.OPENCOMMIT_EMOJI
         ? 'Use Gitmoji convention to preface the commit'
         : 'Do not preface the commit with anything'
     }, use the present tense. ${
-      config?.[CONFIG_KEYS.OPENCOMMIT_DESCRIPTION]
+      config?.OPENCOMMIT_DESCRIPTION
         ? 'Add a short description of what commit is about after the commit message. Don\'t start it with "This commit", just describe the changes.'
         : "Don't add any descriptions to the commit, only commit message."
     }`
@@ -49,9 +49,9 @@ const INIT_MESSAGES_PROMPT: Array<ChatCompletionRequestMessage> = [
   {
     role: ChatCompletionRequestMessageRoleEnum.Assistant,
     // prettier-ignore
-    content: `${config?.[CONFIG_KEYS.OPENCOMMIT_EMOJI] ? '🐛 ' : ''}fix(server.ts): change port variable case from lowercase port to uppercase PORT
-${config?.[CONFIG_KEYS.OPENCOMMIT_EMOJI] ? '✨ ' : ''}feat(server.ts): add support for process.env.PORT environment variable
-${config?.[CONFIG_KEYS.OPENCOMMIT_DESCRIPTION] ? 'The port variable is now named PORT, which improves consistency with the naming conventions as PORT is a constant. Support for an environment variable allows the application to be more flexible as it can now run on any available port specified via the process.env.PORT environment variable.' : ''}`
+    content: `${config?.OPENCOMMIT_EMOJI ? '🐛 ' : ''}fix(server.ts): change port variable case from lowercase port to uppercase PORT
+${config?.OPENCOMMIT_EMOJI ? '✨ ' : ''}feat(server.ts): add support for process.env.PORT environment variable
+${config?.OPENCOMMIT_DESCRIPTION ? 'The port variable is now named PORT, which improves consistency with the naming conventions as PORT is a constant. Support for an environment variable allows the application to be more flexible as it can now run on any available port specified via the process.env.PORT environment variable.' : ''}`
   }
 ];