Skip to content

Commit 2f7924d

Browse files
pridhivirajstewartsmith
authored andcommitted
Try HPM Update one more time if it fails for the first time.
Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
1 parent 43d9d88 commit 2f7924d

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

testcases/OpTestFlash.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
import OpTestConfiguration
4646
from common.OpTestSystem import OpSystemState
4747
from common.OpTestConstants import OpTestConstants as BMC_CONST
48-
48+
from common.OpTestError import OpTestError
4949

5050
class OpTestFlashBase(unittest.TestCase):
5151
def setUp(self):
@@ -131,7 +131,10 @@ def runTest(self):
131131
self.cv_SYSTEM.sys_sdr_clear()
132132
self.validate_side_activated()
133133
self.cv_SYSTEM.goto_state(OpSystemState.OFF)
134-
self.cv_IPMI.ipmi_code_update(self.hpm_path, str(BMC_CONST.BMC_FWANDPNOR_IMAGE_UPDATE))
134+
try:
135+
self.cv_IPMI.ipmi_code_update(self.hpm_path, str(BMC_CONST.BMC_FWANDPNOR_IMAGE_UPDATE))
136+
except OpTestError:
137+
self.cv_IPMI.ipmi_code_update(self.hpm_path, str(BMC_CONST.BMC_FWANDPNOR_IMAGE_UPDATE))
135138
self.cv_SYSTEM.goto_state(OpSystemState.OS)
136139
self.validate_side_activated()
137140
self.cv_SYSTEM.sys_sel_check()
@@ -152,7 +155,10 @@ def runTest(self):
152155
self.skipTest("OP AMI BMC In-band firmware Update test")
153156
self.cv_SYSTEM.sys_sdr_clear()
154157
self.validate_side_activated()
155-
self.cv_HOST.host_code_update(self.hpm_path, str(BMC_CONST.BMC_FWANDPNOR_IMAGE_UPDATE))
158+
try:
159+
self.cv_HOST.host_code_update(self.hpm_path, str(BMC_CONST.BMC_FWANDPNOR_IMAGE_UPDATE))
160+
except OpTestError:
161+
self.cv_HOST.host_code_update(self.hpm_path, str(BMC_CONST.BMC_FWANDPNOR_IMAGE_UPDATE))
156162
self.cv_SYSTEM.goto_state(OpSystemState.OFF)
157163
self.cv_SYSTEM.goto_state(OpSystemState.OS)
158164
self.validate_side_activated()

0 commit comments

Comments
 (0)