Skip to content

Commit b27a57a

Browse files
committed
doc: futher document how Qemu support works
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
1 parent eb1c7d0 commit b27a57a

1 file changed

Lines changed: 15 additions & 1 deletion

File tree

common/OpTestQemu.py

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@
1818
# implied. See the License for the specific language governing
1919
# permissions and limitations under the License.
2020

21-
# Support testing against Qemu simulator
21+
"""
22+
Support testing against Qemu simulator
23+
"""
2224

2325
import atexit
2426
import sys
@@ -35,6 +37,10 @@ class ConsoleState():
3537
CONNECTED = 1
3638

3739
class QemuConsole():
40+
"""
41+
A 'connection' to the Qemu Console involves *launching* qemu.
42+
Terminating a connection will *terminate* the qemu process.
43+
"""
3844
def __init__(self, qemu_binary=None, skiboot=None, kernel=None, initramfs=None, logfile=sys.stdout, hda=None, ubuntu_cdrom=None):
3945
self.qemu_binary = qemu_binary
4046
self.skiboot = skiboot
@@ -134,13 +140,21 @@ def run_command_ignore_fail(self, command, timeout=60):
134140
return output
135141

136142
class QemuIPMI():
143+
"""
144+
Qemu has fairly limited IPMI capability, and we probably need to
145+
extend the capability checks so that more of the IPMI test suite
146+
gets skipped.
147+
148+
"""
137149
def __init__(self, console):
138150
self.console = console
139151

140152
def ipmi_power_off(self):
153+
"""For Qemu, this just kills the simulator"""
141154
self.console.terminate()
142155

143156
def ipmi_wait_for_standby_state(self, i_timeout=10):
157+
"""For Qemu, we just kill the simulator"""
144158
self.console.terminate()
145159

146160
def ipmi_set_boot_to_petitboot(self):

0 commit comments

Comments
 (0)