Merge remote-tracking branch 'upstream/main' #4
openmind-whypresubmit.yml
on: push
[Required] Check correct format
55s
[Required] Check docs updated
35s
Annotations
10 errors
|
[Required] Check docs updated
Process completed with exit code 2.
|
|
[Required] Check docs updated:
src/tools/emulation.ts#L172
Parameter 'page' implicitly has an 'any' type.
|
|
[Required] Check docs updated:
src/tools/emulation.ts#L168
Property 'getPages' does not exist on type 'Readonly<{ isRunningPerformanceTrace(): boolean; setIsRunningPerformanceTrace(x: boolean): void; recordedTraces(): TraceResult[]; storeTraceRecording(result: TraceResult): void; ... 16 more ...; waitForTextOnPage(params: { ...; }): Promise<...>; }>'.
|
|
[Required] Check docs updated:
src/tools/emulation.ts#L167
Property 'createPagesSnapshot' does not exist on type 'Readonly<{ isRunningPerformanceTrace(): boolean; setIsRunningPerformanceTrace(x: boolean): void; recordedTraces(): TraceResult[]; storeTraceRecording(result: TraceResult): void; ... 16 more ...; waitForTextOnPage(params: { ...; }): Promise<...>; }>'.
|
|
[Required] Check correct format
Process completed with exit code 1.
|
|
[Required] Check correct format:
src/tools/emulation.ts#L192
'error' is defined but never used
|
|
[Required] Check correct format:
src/tools/emulation.ts#L151
'customUserAgent' is never reassigned. Use 'const' instead
|
|
[Required] Check correct format:
src/tools/emulation.ts#L8
`puppeteer-core` import should occur before import of `../third_party/index.js`
|
|
[Required] Check correct format:
src/tools/emulation.ts#L8
There should be at least one empty line between import groups
|
|
[Required] Check correct format:
src/tools/emulation.ts#L7
There should be at least one empty line between import groups
|