[chores] Minor improvements to close_stale_sessions

- Loop over sessions using iterator()
- Use "Session-Timeout" as terminate cause

Author: nemesifier

openwisp_radius/base/models.py

@@ -549,12 +549,12 @@ def close_stale_sessions(cls, days=None, hours=None):
                 | (Q(update_time=None) & Q(start_time__lt=older_than))
             )
         )
-        for session in sessions:
+        for session in sessions.iterator():
             # calculate seconds in between two dates
             session.session_time = (now() - session.start_time).total_seconds()
             session.stop_time = now()
             session.update_time = session.stop_time
-            session.terminate_cause = "Session Timeout"
+            session.terminate_cause = "Session-Timeout"
             session.save()
 
     @classmethod

openwisp_radius/tests/test_commands.py

@@ -40,7 +40,7 @@ def test_cleanup_stale_radacct_command(self):
             self.assertNotEqual(session.stop_time, None)
             self.assertNotEqual(session.session_time, None)
             self.assertEqual(session.update_time, session.stop_time)
-            self.assertEqual(session.terminate_cause, "Session Timeout")
+            self.assertEqual(session.terminate_cause, "Session-Timeout")
 
         with self.subTest(
             "Test start_time older than specified time but update_time is recent"
@@ -67,7 +67,7 @@ def test_cleanup_stale_radacct_command(self):
             self.assertNotEqual(session.stop_time, None)
             self.assertNotEqual(session.session_time, None)
             self.assertEqual(session.update_time, session.stop_time)
-            self.assertEqual(session.terminate_cause, "Session Timeout")
+            self.assertEqual(session.terminate_cause, "Session-Timeout")
 
         with self.subTest("Test start_time and update_time older than specified hours"):
             options["unique_id"] = "120"
@@ -79,7 +79,7 @@ def test_cleanup_stale_radacct_command(self):
             self.assertNotEqual(session.stop_time, None)
             self.assertNotEqual(session.session_time, None)
             self.assertEqual(session.update_time, session.stop_time)
-            self.assertEqual(session.terminate_cause, "Session Timeout")
+            self.assertEqual(session.terminate_cause, "Session-Timeout")
 
         with self.subTest("Test does not affect closed session"):
             options["unique_id"] = "121"
@@ -96,7 +96,7 @@ def test_cleanup_stale_radacct_command(self):
                 "2017-06-10 10:55:00",
             )
             self.assertEqual(session.update_time, session.stop_time)
-            self.assertNotEqual(session.terminate_cause, "Session Timeout")
+            self.assertNotEqual(session.terminate_cause, "Session-Timeout")
 
     @capture_any_output()
     def test_delete_old_postauth_command(self):