[fix] FreeRADIUS API: forgive empty input_octets/output_octets

Author: nemesifier

openwisp_radius/api/serializers.py

@@ -200,12 +200,12 @@ def run_validation(self, data):
             # let's set zero as default value
             if data.get("status_type", None) == "Start" and data.get(field) == "":
                 data[field] = 0
-            # missing data in accounting stop,
+            # missing data in accounting data,
             # let's remove the empty string to
             # prevent the API from failing
             # the existing values stored in previous
             # interim-updates won't be changed
-            if data.get("status_type", None) == "Stop" and data.get(field) == "":
+            if data.get("status_type", None) != "Start" and data.get(field) == "":
                 del data[field]
         return super().run_validation(data)
 

openwisp_radius/tests/test_api/test_freeradius_api.py

@@ -603,6 +603,26 @@ def test_accounting_update_200(self):
         data["terminate_cause"] = ""
         self.assertAcctData(ra, data)
 
+    @freeze_time(START_DATE)
+    def test_accounting_update_missing_octets(self):
+        self.assertEqual(RadiusAccounting.objects.count(), 0)
+        ra = self._create_radius_accounting(**self._acct_initial_data)
+        data = self.acct_post_data
+        data["status_type"] = "Interim-Update"
+        data["input_octets"] = ""
+        data["output_octets"] = ""
+        data = self._get_accounting_params(**data)
+        response = self.post_json(data)
+        self.assertEqual(response.status_code, 200)
+        self.assertIsNone(response.data)
+        self.assertEqual(RadiusAccounting.objects.count(), 1)
+        ra.refresh_from_db()
+        self.assertEqual(ra.update_time.timetuple(), now().timetuple())
+        data["terminate_cause"] = ""
+        data["input_octets"] = 0
+        data["output_octets"] = 0
+        self.assertAcctData(ra, data)
+
     @mock.patch.object(
         app_settings,
         "CALLED_STATION_IDS",