Skip to content

Commit 7ee8504

Browse files
authored
fix: Use correct browser suffixes in constants (#315)
1 parent ff4d003 commit 7ee8504

2 files changed

Lines changed: 7 additions & 9 deletions

File tree

‎src/choreographer/browser_async.py‎

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -180,13 +180,11 @@ def run() -> subprocess.Popen[bytes] | subprocess.Popen[str]: # depends on args
180180
break
181181
except (BrowserClosedError, BrowserFailedError, asyncio.CancelledError) as e:
182182
raise BrowserFailedError(
183-
"The browser seemed to close immediately after starting.",
184-
"You can set the `logging.Logger` level lower to see more output.",
185-
"You may try installing a known working copy of Chrome by running ",
186-
"`$ choreo_get_chrome`."
187-
""
188-
"It may be your browser auto-updated and will now work upon "
189-
"restart. The browser we tried to start is located at "
183+
"The browser seemed to close immediately after starting. "
184+
"You can set the `logging.Logger` level lower to see more output. "
185+
"You may try installing a known working copy of Chrome by running "
186+
"`$ choreo_get_chrome`. It may be your browser auto-updated and will "
187+
"now work upon restart. The browser we tried to start is located at "
190188
f"{self._browser_impl.path}.",
191189
) from e
192190

‎src/choreographer/browsers/_chrome_constants.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,10 @@
5050
typical_edge_paths = tuple(_p + _edge_suffix for _p in _windows_app_dirs)
5151

5252
_brave_suffix = r"\BraveSoftware\Brave-Browser\Application\brave.exe"
53-
typical_brave_paths = tuple(_p + _edge_suffix for _p in _windows_app_dirs)
53+
typical_brave_paths = tuple(_p + _brave_suffix for _p in _windows_app_dirs)
5454

5555
_vivaldi_suffix = r"\Vivaldi\Application\vivaldi.exe"
56-
typical_vivaldi_paths = tuple(_p + _brave_suffix for _p in _windows_app_dirs)
56+
typical_vivaldi_paths = tuple(_p + _vivaldi_suffix for _p in _windows_app_dirs)
5757

5858
elif platform.system() == "Linux":
5959
typical_chrome_paths = (

0 commit comments

Comments
 (0)