Skip to content

Commit 4d0708d

Browse files
authored
Cleanup pull request signing
Contributors do not have access to the repo's secrets
1 parent 0dca823 commit 4d0708d

1 file changed

Lines changed: 1 addition & 16 deletions

File tree

.github/workflows/pull_request.yml

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -52,27 +52,12 @@ jobs:
5252
architecture: ${{ matrix.arch }}
5353
- name: Setup Ant
5454
uses: cedx/setup-ant@v3
55-
- name: Install Certificates for Code Signing
56-
if: ${{ matrix.os_prefix == 'macos' }}
57-
uses: apple-actions/import-codesign-certs@v3
58-
with:
59-
p12-file-base64: ${{ secrets.CERTIFICATES_P12 }}
60-
p12-password: ${{ secrets.CERTIFICATES_P12_PASSWORD }}
6155
- name: Build Release
62-
run: ant -noinput -buildfile build/build.xml ${{ matrix.os_prefix }}-dist -Dversion="${{ github.sha }}"
63-
env:
64-
PROCESSING_APP_SIGNING: true
56+
run: ant -noinput -buildfile build/build.xml ${{ matrix.os_prefix }}-dist -Dversion="${{ github.sha }}
6557
- name: Add artifact
6658
uses: actions/upload-artifact@v3
6759
id: upload
6860
with:
6961
name: processing-${{github.sha}}${{ matrix.os_prefix }}-${{ matrix.arch }}
7062
path: ./build/${{ matrix.os_prefix }}/processing-${{github.sha}}-${{ matrix.os_prefix}}-*
7163
retention-days: 5
72-
# TODO: Merge into one comment and fix the link
73-
# - uses: mshick/add-pr-comment@v2
74-
# with:
75-
# message-id: "build-artifact ${{ matrix.os_prefix }} ${{ matrix.arch }}"
76-
# message: |
77-
# Build artifacts for ${{ matrix.os_prefix }} (${{ matrix.arch }}) have been created.
78-
# Download the artifacts [here](${{ steps.upload.outputs.artifact-id }}).

0 commit comments

Comments
 (0)