refactor(common): rename ocre_is_valid_id to ocre_is_valid_name

As this will check if a user specified name is valid or not.

In the future we will want the container name to be unrelated from
the ID, so we take the change to rename and decouple it here, now.

Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>

Author: casaroli

src/common/common.c

@@ -2,7 +2,7 @@
 #include <ctype.h>
 #include <string.h>
 
-int ocre_is_valid_id(const char *id)
+int ocre_is_valid_name(const char *id)
 {
 	/* Cannot be NULL */
 

src/common/include/ocre/common.h

@@ -9,16 +9,16 @@
 #define OCRE_COMMON_H
 
 /**
- * @brief Check if a container or image ID is valid
+ * @brief Check if a container or image names is valid
  * @memberof ocre_context
  *
- * Checks if a container or image ID is valid. A valid container or image ID must not be NULL, empty, or start with a
- * dot '.'. It can only contain alphanumeric characters, dots, underscores, and hyphens.
+ * Checks if a container or image name is valid. A valid container or image name must not be NULL, empty, or start with
+ * a dot '.'. It can only contain alphanumeric characters, dots, underscores, and hyphens.
  *
  * @param id A pointer to the container or image ID to check
  *
  * @return Zero if invalid, 1 if valid
  */
-int ocre_is_valid_id(const char *id);
+int ocre_is_valid_name(const char *id);
 
 #endif /* OCRE_COMMON_H */

src/ocre/context.c

@@ -187,7 +187,7 @@ struct ocre_container *ocre_context_create_container(struct ocre_context *contex
 
 	/* Check if the provided container ID is valid */
 
-	if (container_id && !ocre_is_valid_id(container_id)) {
+	if (container_id && !ocre_is_valid_name(container_id)) {
 		LOG_ERR("Invalid characters in container ID '%s'. Valid are [a-z0-9_-.] (lowercase alphanumeric) and "
 			"cannot start with '.'",
 			container_id);
@@ -196,7 +196,7 @@ struct ocre_container *ocre_context_create_container(struct ocre_context *contex
 
 	/* Check if the provided image ID is valid */
 
-	if (!image || !ocre_is_valid_id(image)) {
+	if (!image || !ocre_is_valid_name(image)) {
 		LOG_ERR("Invalid characters in image ID '%s'. Valid are [a-z0-9_-.] (lowercase alphanumeric) and "
 			"cannot start with '.'",
 			image);

src/shell/container/create.c

@@ -81,7 +81,7 @@ int cmd_container_create_run(struct ocre_context *ctx, const char *argv0, int ar
 
 				/* Check if the provided container ID is valid */
 
-				if (optarg && !ocre_is_valid_id(optarg)) {
+				if (optarg && !ocre_is_valid_name(optarg)) {
 					fprintf(stderr,
 						"Invalid characters in container ID '%s'. Valid are [a-z0-9_-.] "
 						"(lowercase alphanumeric) and cannot start with '.'\n",
@@ -200,7 +200,7 @@ int cmd_container_create_run(struct ocre_context *ctx, const char *argv0, int ar
 
 	/* Check if the provided image ID is valid */
 
-	if (argv[optind] && !ocre_is_valid_id(argv[optind])) {
+	if (argv[optind] && !ocre_is_valid_name(argv[optind])) {
 		fprintf(stderr,
 			"Invalid characters in image ID '%s'. Valid are [a-z0-9_-.] (lowercase alphanumeric) and "
 			"cannot start with '.'",

src/shell/image/ls.c

@@ -124,7 +124,7 @@ int cmd_image_ls(struct ocre_context *ctx, const char *argv0, int argc, char **a
 
 			/* Check if the provided image ID is valid */
 
-			if (argv[1] && !ocre_is_valid_id(argv[1])) {
+			if (argv[1] && !ocre_is_valid_name(argv[1])) {
 				fprintf(stderr,
 					"Invalid characters in image ID '%s'. Valid are [a-z0-9_-.] (lowercase "
 					"alphanumeric) and cannot start with '.'\n",

src/shell/image/pull.c

@@ -54,7 +54,7 @@ int cmd_image_pull(struct ocre_context *ctx, const char *argv0, int argc, char *
 
 	/* Check if the provided image ID is valid */
 
-	if (!ocre_is_valid_id(local_name)) {
+	if (!ocre_is_valid_name(local_name)) {
 		fprintf(stderr,
 			"Invalid characters in image ID '%s'. Valid are [a-z0-9_-.] (lowercase "
 			"alphanumeric) and cannot start with '.'\n",

src/shell/image/rm.c

@@ -26,7 +26,7 @@ int cmd_image_rm(struct ocre_context *ctx, const char *argv0, int argc, char **a
 	if (argc == 2) {
 		/* Check if the provided image ID is valid */
 
-		if (argv[1] && !ocre_is_valid_id(argv[1])) {
+		if (argv[1] && !ocre_is_valid_name(argv[1])) {
 			fprintf(stderr,
 				"Invalid characters in image ID '%s'. Valid are [a-z0-9_-.] (lowercase "
 				"alphanumeric) and cannot start with '.'\n",