Skip to content

Commit 1e1f90d

Browse files
henryiiibhrutledge
andcommitted
Apply suggestions from code review
Co-authored-by: Brian Rutledge <brian@bhrutledge.com>
1 parent 9b728ac commit 1e1f90d

1 file changed

Lines changed: 7 additions & 11 deletions

File tree

source/guides/packaging-binary-extensions.rst

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -240,13 +240,11 @@ that you have a suitable compiler available. On Windows, Visual C is used to
240240
build the official CPython interpreter, and should be used to build compatible
241241
binary extensions.
242242

243-
Python 2.7 used Visual Studio 2008, and Python 3.5+ uses Visual Studio 2015 or
244-
later; since 2015 Microsoft has kept backward compatibility (with one exception,
245-
listed below). Unfortunately, older versions of Visual Studio are no longer
246-
available from Microsoft, so building for CPython < 3.5 is discouraged. If you do
243+
Building for Python prior to 3.5 is discouraged, because older versions of
244+
Visual Studio are no longer available from Microsoft. If you do
247245
need to build for older versions, you can set ``DISTUTILS_USE_SDK=1`` and
248246
``MSSdk=1`` to force a the currently activated version of MSVC to be found,
249-
and you should exercize care when designing your extension not to malloc/free
247+
and you should exercise care when designing your extension not to malloc/free
250248
memory across different libraries, avoid relying on changed data structures,
251249
and so on. Tools for generating extension modules usually avoid these things
252250
for you.
@@ -255,14 +253,12 @@ To set up a build environment for binary extensions, install
255253
`Visual Studio Community Edition <https://www.visualstudio.com/en-us/downloads/download-visual-studio-vs.aspx>`__ - any
256254
recent version is fine.
257255

258-
One caveat; if you use MSVC 2019+, your extension will depend on an "extra"
259-
file, ``VCRUNTIME140_1.dll``, in addition to the ``VCRUNTIME140.dll`` all previous
256+
One caveat: if you use Visual Studio 2019 or later, your extension will depend on an "extra"
257+
file, ``VCRUNTIME140_1.dll``, in addition to the ``VCRUNTIME140.dll`` that all previous
260258
verisions back to 2015 depend on. This will add an extra requirement to using
261-
your extension on versions of CPython that do not include this extra file; you
262-
can add the compile-time argument ``/d2FH4-`` to avoid this link on 2019+.
259+
your extension on versions of CPython that do not include this extra file. To
260+
avoid this, you can add the compile-time argument ``/d2FH4-``.
263261

264-
Building with the recommended compiler on Windows ensures that a compatible C library
265-
is used throughout the Python process.
266262

267263
Binary extensions for Linux
268264
---------------------------

0 commit comments

Comments
 (0)