Skip to content

Commit 69adfc5

Browse files
committed
Feedback
Signed-off-by: William Woodruff <william@astral.sh>
1 parent eb953de commit 69adfc5

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

source/guides/packaging-namespace-packages.rst

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ Legacy namespace packages
159159

160160
These two methods, that were used to create namespace packages prior to :pep:`420`,
161161
are now considered to be obsolete and should not be used unless you need compatibility
162-
with packages already using this method.
162+
with packages already using one of these methods.
163163

164164
To migrate an existing package, all packages sharing the namespace must be migrated simultaneously.
165165

@@ -175,7 +175,7 @@ pkgutil-style namespace packages
175175
Python 2.3 introduced the :doc:`pkgutil <python:library/pkgutil>` module and the
176176
:py:func:`python:pkgutil.extend_path` function. This can be used to declare namespace
177177
packages that need to be compatible with both Python 2.3+ and Python 3. This
178-
is the recommended approach for the highest level of compatibility.
178+
was the recommended approach for the highest level of compatibility.
179179

180180
To create a pkgutil-style namespace package, you need to provide an
181181
:file:`__init__.py` file for the namespace package:
@@ -224,8 +224,8 @@ pkg_resources-style namespace packages
224224

225225
:doc:`Setuptools <setuptools:index>` previously provided the ``pkg_resources.declare_namespace`` function and
226226
the ``namespace_packages`` argument to :func:`~setuptools.setup`. Together
227-
these can be used to declare namespace packages. While this approach is no
228-
longer recommended, it is widely present in most existing namespace packages.
227+
these could be used to declare namespace packages. While this approach is no
228+
supported, it may still be encountered in environments using older ``setuptools`` versions.
229229
If you are creating a new distribution within an existing namespace package that
230230
uses this method then it's recommended to continue using this as the different
231231
methods are not cross-compatible and it's not advisable to try to migrate an
@@ -287,9 +287,3 @@ to :func:`~setuptools.setup` in :file:`setup.py`. For example:
287287
packages=find_packages()
288288
namespace_packages=['mynamespace']
289289
)
290-
291-
A complete working example of two pkg_resources-style namespace packages can be found
292-
in the `pkg_resources namespace example project`_.
293-
294-
.. _pkg_resources namespace example project:
295-
https://github.com/pypa/sample-namespace-packages/tree/master/pkg_resources

0 commit comments

Comments
 (0)