Skip to content

Commit dcfa4b7

Browse files
committed
Refer to PyPI API tokens as such in GitHub secret names, spell in uppercase
GitHub seems to default to uppercase nowadays, and in PyPI terms this is about API tokens instead of passwords as such. Refs pypa/gh-action-pypi-publish#52 (review)
1 parent 9ef40af commit dcfa4b7

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

source/guides/github-actions-ci-cd-sample/publish-to-test-pypi.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ jobs:
3131
- name: Publish distribution 📦 to Test PyPI
3232
uses: pypa/gh-action-pypi-publish@master
3333
with:
34-
password: ${{ secrets.test_pypi_password }}
34+
password: ${{ secrets.TEST_PYPI_API_TOKEN }}
3535
repository_url: https://test.pypi.org/legacy/
3636
- name: Publish distribution 📦 to PyPI
3737
if: startsWith(github.ref, 'refs/tags')
3838
uses: pypa/gh-action-pypi-publish@master
3939
with:
40-
password: ${{ secrets.pypi_password }}
40+
password: ${{ secrets.PYPI_API_TOKEN }}

source/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@ Let's begin! 🚀
3737
2. In a separate browser tab or window, go to the ``Settings``
3838
tab of your target repository and then click on `Secrets`_
3939
in the left sidebar.
40-
3. Create a new secret called ``pypi_password`` and copy-paste
40+
3. Create a new secret called ``PYPI_API_TOKEN`` and copy-paste
4141
the token from the fist step.
4242
4. Now, go to https://test.pypi.org/manage/account/#api-tokens
4343
and repeat the steps. Save that TestPyPI token on GitHub
44-
as ``test_pypi_password``.
44+
as ``TEST_PYPI_API_TOKEN``.
4545

4646
.. attention::
4747

0 commit comments

Comments
 (0)