Skip to content

Commit 7b8ab73

Browse files
gnikonorovsallner
authored andcommitted
respond to review feedback for better assertion failure messages
1 parent dc407ba commit 7b8ab73

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

test_pytest_rerunfailures.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,13 @@ def temporary_failure(count=1):
1818
count)
1919

2020

21+
def check_outcome_field(outcomes, field_name, expected_value):
22+
field_value = outcomes.get(field_name, 0)
23+
assert field_value == expected_value, \
24+
"outcomes.{} has unexpected value. Expected '{}' but got '{}'" \
25+
.format(field_name, expected_value, field_value)
26+
27+
2128
def assert_outcomes(result, passed=1, skipped=0, failed=0, error=0, xfailed=0,
2229
xpassed=0, rerun=0):
2330
outcomes = result.parseoutcomes()
@@ -29,11 +36,6 @@ def assert_outcomes(result, passed=1, skipped=0, failed=0, error=0, xfailed=0,
2936
check_outcome_field(outcomes, 'rerun', rerun)
3037

3138

32-
def check_outcome_field(outcomes, field_name, expected_value):
33-
field_value = outcomes.get(field_name, 0)
34-
assert field_value == expected_value, "outcomes.{} has unexpected value. Expected '{}' but got '{}'".format(field_name, expected_value, field_value)
35-
36-
3739
def test_error_when_run_with_pdb(testdir):
3840
testdir.makepyfile('def test_pass(): pass')
3941
result = testdir.runpytest('--reruns', '1', '--pdb')

0 commit comments

Comments
 (0)