fix: error in function contexts for no-hooks-from-ancestor-modules (#615)

* fix: no-hooks-from-ancestor-modules in function contexts

Fixes an error:

```
TypeError: Cannot read properties of undefined (reading 'hookIdentifierName')
```

* implement suggestions from the review

* Update lib/rules/no-hooks-from-ancestor-modules.js

Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>

---------

Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>

Author: cvx

lib/rules/no-hooks-from-ancestor-modules.js

@@ -120,17 +120,17 @@ module.exports = {
                     if (node.arguments.length === 0) {
                         return;
                     }
-                    if (
-                        node.arguments[0].type !== "Literal" ||
-                        node.arguments[0].value === null ||
-                        node.arguments[0].value === undefined
-                    ) {
-                        return;
-                    }
+
+                    const arg = node.arguments[0];
+                    const description =
+                        arg.type === "Literal" && typeof arg.value === "string"
+                            ? arg.value
+                            : context.getSourceCode().getText(arg);
+
                     /** @type {{callExpression: import('eslint').Rule.Node, description: string, hookIdentifierName?: string | null}} */
                     const moduleStackInfo = {
                         callExpression: node,
-                        description: node.arguments[0].value.toString(),
+                        description: description,
                     };
                     const callback = getCallbackArg(node.arguments);
                     if (

tests/lib/rules/no-hooks-from-ancestor-modules.js

@@ -42,6 +42,21 @@ ruleTester.run("no-hooks-from-ancestor-modules", rule, {
         QUnit.module("module");
         `,
         `
+        QUnit.module(123);
+        `,
+        `
+        QUnit.module();
+        `,
+        `
+        QUnit.module(undefined);
+        `,
+        `
+        QUnit.module(null);
+        `,
+        `
+        QUnit.module(someVariable);
+        `,
+        `
         QUnit.module("module", function() { test("it1", function() {}); });
         `,
         `
@@ -131,6 +146,13 @@ ruleTester.run("no-hooks-from-ancestor-modules", rule, {
             });
         });
         `,
+        `
+        function foo(name) {
+            QUnit.module(name, function (hooks) {
+                hooks.beforeEach(function () {});
+            });
+        }
+        `,
 
         {
             // TypeScript: module callback is adding a type to `this`
@@ -302,5 +324,23 @@ ruleTester.run("no-hooks-from-ancestor-modules", rule, {
                 }),
             ],
         },
+
+        {
+            code: `
+                function foo(name) {
+                    QUnit.module(\`\${name} parent\`, function (hooks) {
+                        QUnit.module(name, function () {
+                            hooks.beforeEach(function () {});
+                        });
+                    });
+                }
+            `,
+            errors: [
+                createError({
+                    invokedMethodName: "beforeEach",
+                    usedHooksIdentifierName: "hooks",
+                }),
+            ],
+        },
     ],
 });