fix(Event Handling): Clicking on the card should not prevent default click behaviour

rcdexta · rcdexta · commit 244339f7cbf9 · 2018-12-29T17:51:00.000-08:00
This was added as a side-effect when using react-smooth-dnd for DnD. This is no longer applicable #150
diff --git a/src/components/Lane.js b/src/components/Lane.js
@@ -78,7 +78,6 @@ class Lane extends Component {
     const {onCardClick} = this.props
     onCardClick && onCardClick(card.id, card.metadata, card.laneId)
     e.stopPropagation()
-    e.preventDefault()
   }
 
   showEditableCard = () => {
diff --git a/src/styles/Base.js b/src/styles/Base.js
@@ -52,7 +52,6 @@ export const Section = styled.section`
 `
 
 export const LaneHeader = styled(Header)`
-	z-index: 1000;
 	padding: 0px 5px;
 	margin-bottom: 0px;
 `
diff --git a/stories/EditableBoard.story.js b/stories/EditableBoard.story.js
@@ -84,6 +84,6 @@ storiesOf('Editable Board', module)
   .add(
     'Add New Lane',
     withInfo('Allow adding new lane')(() => {
-      return <Board data={smallData} editable />
+      return <Board data={smallData} editable canAddLanes />
     })
   )

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,6 @@ class Lane extends Component {`
`78`	`78`	`const {onCardClick} = this.props`
`79`	`79`	`onCardClick && onCardClick(card.id, card.metadata, card.laneId)`
`80`	`80`	`e.stopPropagation()`
`81`		`- e.preventDefault()`
`82`	`81`	`}`
`83`	`82`
`84`	`83`	`showEditableCard = () => {`
Original file line number	Diff line number	Diff line change
@@ -52,7 +52,6 @@ export const Section = styled.section`
`52`	`52`	`
`53`	`53`
`54`	`54`	export const LaneHeader = styled(Header)`
`55`		`- z-index: 1000;`
`56`	`55`	`padding: 0px 5px;`
`57`	`56`	`margin-bottom: 0px;`
`58`	`57`	`
Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,6 @@ storiesOf('Editable Board', module)`
`84`	`84`	`.add(`
`85`	`85`	`'Add New Lane',`
`86`	`86`	`withInfo('Allow adding new lane')(() => {`
`87`		`- return <Board data={smallData} editable />`
	`87`	`+ return <Board data={smallData} editable canAddLanes />`
`88`	`88`	`})`
`89`	`89`	`)`