Skip to content

Commit 2e716fc

Browse files
committed
fix: Get rid of shouldComponentUpdate lifecycle method in Lane
This was added to whitelist attributes to look for re-render since react-dnd was injecting multiple prop values which was causing all lanes to re-render when the cards are dragged. Now, we have rewritten the dragging feature, so this can be removed #92
1 parent 47e7bc0 commit 2e716fc

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

src/components/Lane.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,6 @@ class Lane extends Component {
7373
this.props.actions.removeCard({laneId: laneId, cardId: cardId})
7474
}
7575

76-
shouldComponentUpdate(nextProps, nextState) {
77-
return !isEqual(this.props.cards, nextProps.cards) || nextState !== this.state
78-
}
79-
8076
handleCardClick = (e, card) => {
8177
const {onCardClick} = this.props
8278
onCardClick && onCardClick(card.id, card.metadata, card.laneId)

0 commit comments

Comments
 (0)