Merge pull request #58 from lowsky/fixing-lint-warnings

Adding more propType definitions

Author: rcdexta

.eslintignore

@@ -1,4 +1,3 @@
-lib
 **/node_modules
 **/webpack.config.js
-examples/**/server.js
+/dist/

.eslintrc

@@ -1,20 +1,10 @@
 {
   "parser": "babel-eslint",
   "rules": {
-    "strict": 0,
-    "no-fallthrough": 0,
-    "react/prop-types": 0,
-    "prettier/prettier": ["error", {
-      "printWidth": 120,
-      "singleQuote": true,
-      "trailingComma": "none",
-      "bracketSpacing": false,
-      "jsxBracketSameLine": true,
-      "arrowParens": "avoid",
-      "semi": false,
-      "tabWidth": 2,
-      "useTabs": false
-    }]
+    "strict": 1,
+    "no-undef": 1,
+    "no-fallthrough": 1,
+    "react/prop-types": 2
   },
   "extends": ["standard", "standard-react", "plugin:prettier/recommended"],
   "env": {

.gitignore

@@ -3,9 +3,5 @@ node_modules
 .DS_Store
 coverage
 .idea
-examples/bundle.js
-examples/style.css
 npm-debug.log
-.idea
 dist/
-*.iml

.prettierrc

@@ -0,0 +1,11 @@
+{
+  "printWidth": 120,
+  "singleQuote": true,
+  "trailingComma": "none",
+  "bracketSpacing": false,
+  "jsxBracketSameLine": true,
+  "arrowParens": "avoid",
+  "semi": false,
+  "tabWidth": 2,
+  "useTabs": false
+}

package.json

@@ -48,7 +48,7 @@
     "autoprefixer": "^7.1.1",
     "babel-cli": "^6.26.0",
     "babel-core": "^6.26.0",
-    "babel-eslint": "^6.1.2",
+    "babel-eslint": "^8.2.1",
     "babel-jest": "^21.0.0",
     "babel-plugin-transform-async-to-generator": "^6.24.1",
     "babel-plugin-transform-object-rest-spread": "^6.23.0",

src/components/BoardContainer.js

@@ -9,7 +9,7 @@ import Lane from './Lane'
 
 import * as boardActions from '../actions/BoardActions'
 import * as laneActions from '../actions/LaneActions'
-import {DragDropContext, Droppable} from 'react-beautiful-dnd'
+import {DragDropContext} from 'react-beautiful-dnd'
 
 class BoardContainer extends Component {
   wireEventBus = () => {
@@ -105,7 +105,9 @@ class BoardContainer extends Component {
 }
 
 BoardContainer.propTypes = {
+  actions: PropTypes.object,
   data: PropTypes.object.isRequired,
+  reducerData: PropTypes.object,
   onDataChange: PropTypes.func,
   eventBusHandle: PropTypes.func,
   onLaneScroll: PropTypes.func,

src/components/Card.js

@@ -46,21 +46,20 @@ class Card extends Component {
           const dragStyle = this.getItemStyle(dragSnapshot.isDragging, dragProvided.draggableProps.style)
           return (
             <div>
-                <MovableCardWrapper
-                  key={id}
-                  data-id={id}
-                  innerRef={dragProvided.innerRef}
-                  {...dragProvided.draggableProps}
-                  {...dragProvided.dragHandleProps}
-									style={{
-										...style,
-										...dragStyle
-									}}
-									{...otherProps}
-                >
-                  {this.renderBody()}
-                  {editable && <DeleteButton onClick={this.removeCard} />}
-                </MovableCardWrapper>
+              <MovableCardWrapper
+                key={id}
+                data-id={id}
+                innerRef={dragProvided.innerRef}
+                {...dragProvided.draggableProps}
+                {...dragProvided.dragHandleProps}
+                style={{
+                  ...style,
+                  ...dragStyle
+                }}
+                {...otherProps}>
+                {this.renderBody()}
+                {editable && <DeleteButton onClick={this.removeCard} />}
+              </MovableCardWrapper>
               {dragProvided.placeholder}
             </div>
           )
@@ -80,13 +79,19 @@ Card.defaultProps = {
 Card.propTypes = {
   id: PropTypes.string.isRequired,
   title: PropTypes.string,
+  index: PropTypes.number,
   description: PropTypes.string,
   label: PropTypes.string,
+  tags: PropTypes.array,
+  laneId: PropTypes.string.isRequired,
+  removeCard: PropTypes.func,
   onClick: PropTypes.func,
   onDelete: PropTypes.func,
   metadata: PropTypes.object,
   handleDragStart: PropTypes.func,
   handleDragEnd: PropTypes.func,
+  cardStyle: PropTypes.object,
+  tagStyle: PropTypes.object,
   customCardLayout: PropTypes.bool,
   customCard: PropTypes.node,
   editable: PropTypes.bool

src/components/Lane.js

@@ -1,26 +1,17 @@
 import React, {Component} from 'react'
-import Loader from './Loader'
 import PropTypes from 'prop-types'
-import Card from './Card'
-import {
-	Section,
-	Header,
-	Title,
-	RightContent,
-	DraggableList,
-	Placeholder,
-	AddCardLink,
-	LaneWrapper,
-	ScrollableLane, LaneHeader,
-} from '../styles/Base';
 import {bindActionCreators} from 'redux'
 import {connect} from 'react-redux'
 import update from 'immutability-helper'
 import isEqual from 'lodash/isEqual'
-import NewCard from './NewCard'
-import {DragDropContext, Droppable, Draggable} from 'react-beautiful-dnd'
+import {Droppable} from 'react-beautiful-dnd'
 import uuidv1 from 'uuid/v1'
 
+import Loader from './Loader'
+import Card from './Card'
+import NewCard from './NewCard'
+import {Section, Title, RightContent, DraggableList, AddCardLink, ScrollableLane, LaneHeader} from '../styles/Base'
+
 import * as laneActions from '../actions/LaneActions'
 
 class Lane extends Component {
@@ -64,7 +55,7 @@ class Lane extends Component {
     })
   }
 
-  laneDidMount = (node) => {
+  laneDidMount = node => {
     if (node) {
       node.addEventListener('scroll', this.handleScroll)
     }
@@ -235,22 +226,31 @@ class Lane extends Component {
 }
 
 Lane.propTypes = {
+  actions: PropTypes.object,
+  children: PropTypes.node,
   id: PropTypes.string.isRequired,
   title: PropTypes.node,
   index: PropTypes.number,
   laneSortFunction: PropTypes.func,
   style: PropTypes.object,
+  cardStyle: PropTypes.object,
+  tagStyle: PropTypes.object,
   titleStyle: PropTypes.object,
   labelStyle: PropTypes.object,
+  customLaneHeader: PropTypes.element,
+  customCardLayout: PropTypes.bool,
   cards: PropTypes.array,
   label: PropTypes.string,
+  currentPage: PropTypes.number,
+  draggable: PropTypes.bool,
   droppable: PropTypes.bool,
   onLaneScroll: PropTypes.func,
   handleDragStart: PropTypes.func,
   handleDragEnd: PropTypes.func,
   onCardClick: PropTypes.func,
   onCardDelete: PropTypes.func,
   onCardAdd: PropTypes.func,
+  onLaneClick: PropTypes.func,
   newCardTemplate: PropTypes.node,
   addCardLink: PropTypes.node,
   editable: PropTypes.bool

src/components/Tag.js

@@ -2,7 +2,7 @@ import React, {Component} from 'react'
 import PropTypes from 'prop-types'
 import {TagSpan} from '../styles/Base'
 
-export default class Tag extends Component {
+class Tag extends Component {
   render() {
     const {title, color, bgcolor, tagStyle, ...otherProps} = this.props
     const style = {color: color || 'white', backgroundColor: bgcolor || 'orange', ...tagStyle}
@@ -14,8 +14,11 @@ export default class Tag extends Component {
   }
 }
 
-Tag.PropTypes = {
-  title: PropTypes.array.isRequired,
+Tag.propTypes = {
+  title: PropTypes.string.isRequired,
   color: PropTypes.string,
-  bgcolor: PropTypes.string
+  bgcolor: PropTypes.string,
+  tagStyle: PropTypes.object
 }
+
+export default Tag

src/components/widgets/EditableLabel.js

@@ -1,13 +1,7 @@
 import React from 'react'
+import PropTypes from 'prop-types'
 
-export default class EditableLabel extends React.Component {
-  static defaultProps = {
-    onChange: () => {},
-    placeholder: '',
-    className: '',
-    autoFocus: false
-  }
-
+class EditableLabel extends React.Component {
   state = {text: ''}
 
   getText = el => {
@@ -54,3 +48,18 @@ export default class EditableLabel extends React.Component {
     )
   }
 }
+
+EditableLabel.defaultProps = {
+  onChange: () => {},
+  placeholder: '',
+  className: '',
+  autoFocus: false
+}
+EditableLabel.propTypes = {
+  onChange: PropTypes.func,
+  placeholder: PropTypes.string,
+  className: PropTypes.string,
+  autoFocus: PropTypes.bool
+}
+
+export default EditableLabel