Skip to content

Commit 129519d

Browse files
Remove dead RCTBridge imports from nine base files (#59320)
Summary: Nine React Base implementation files imported the bridge headers without using any symbol they provide. RCTLog narrows to the module protocol header, which declares the registry interfaces it messages. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D126580392
1 parent 7d5dc64 commit 129519d

9 files changed

Lines changed: 1 addition & 13 deletions

File tree

‎packages/react-native/React/Base/RCTBundleManager.m‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
#import <React/RCTBundleURLProvider.h>
1010
#import <React/RCTDevLoadingViewSetEnabled.h>
1111
#import "RCTAssert.h"
12-
#import "RCTBridge+Private.h"
13-
#import "RCTBridge.h"
1412
#import "RCTLog.h"
1513

1614
@implementation RCTBundleConfiguration

‎packages/react-native/React/Base/RCTCallableJSModules.m‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
#import "RCTBridge.h"
98
#import "RCTBridgeModule.h"
109

1110
@implementation RCTCallableJSModules {

‎packages/react-native/React/Base/RCTJavaScriptLoader.mm‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
#import <cxxreact/JSBundleType.h>
1515

16-
#import "RCTBridge.h"
1716
#import "RCTConvert.h"
1817
#import "RCTMultipartDataTask.h"
1918
#import "RCTPerformanceLogger.h"

‎packages/react-native/React/Base/RCTLog.mm‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@
1313
#import <os/log.h>
1414

1515
#import "RCTAssert.h"
16-
#import "RCTBridge+Private.h"
17-
#import "RCTBridge.h"
16+
#import "RCTBridgeModule.h"
1817
#import "RCTDefines.h"
1918
#import "RCTRedBoxSetEnabled.h"
2019
#import "RCTUtils.h"

‎packages/react-native/React/Base/RCTRootView.m‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
#import <objc/runtime.h>
1212

1313
#import "RCTAssert.h"
14-
#import "RCTBridge+Private.h"
15-
#import "RCTBridge.h"
1614
#import "RCTConstants.h"
1715
#import "RCTKeyCommands.h"
1816
#import "RCTLog.h"

‎packages/react-native/React/Base/RCTTouchHandler.m‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
#import <UIKit/UIGestureRecognizerSubclass.h>
1111

1212
#import "RCTAssert.h"
13-
#import "RCTBridge.h"
1413
#import "RCTEventDispatcherProtocol.h"
1514
#import "RCTLog.h"
1615
#import "RCTSurfaceView.h"

‎packages/react-native/React/Base/RCTViewRegistry.m‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
#import <React/RCTSurfacePresenterStub.h>
99
#import <React/RCTUIManager.h>
1010

11-
#import "RCTBridge.h"
1211
#import "RCTBridgeModule.h"
1312

1413
@implementation RCTViewRegistry {

‎packages/react-native/React/Base/Surface/RCTSurface.mm‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313
#import <stdatomic.h>
1414

1515
#import "RCTAssert.h"
16-
#import "RCTBridge+Private.h"
17-
#import "RCTBridge.h"
1816
#import "RCTConstants.h"
1917
#import "RCTShadowView+Layout.h"
2018
#import "RCTSurfaceDelegate.h"

‎packages/react-native/React/Base/Surface/SurfaceHostingView/RCTSurfaceHostingProxyRootView.mm‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
#import <objc/runtime.h>
1111

1212
#import "RCTAssert.h"
13-
#import "RCTBridge+Private.h"
1413
#import "RCTBridge.h"
1514
#import "RCTLog.h"
1615
#import "RCTPerformanceLogger.h"

0 commit comments

Comments
 (0)