Skip to content

Commit 24d3961

Browse files
christophpurrermeta-codesync[bot]
authored andcommitted
Delete dead RCTBridge category implementations (#59263)
Summary: Pull Request resolved: #59263 RCTBridge is never instantiated, so its nine per-module category implementations never execute. Delete them and keep the proxy implementations plus all interface declarations, which callers still compile against. Changelog: [Internal] Differential Revision: D126574379
1 parent 933e874 commit 24d3961

9 files changed

Lines changed: 0 additions & 103 deletions

File tree

‎packages/react-native/Libraries/Image/RCTImageLoader.mm‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1323,22 +1323,6 @@ - (void)queryCache:(NSArray *)uris resolve:(RCTPromiseResolveBlock)resolve rejec
13231323
}
13241324
@end
13251325

1326-
/**
1327-
* DEPRECATED!! DO NOT USE
1328-
* Instead use `[_bridge moduleForClass:[RCTImageLoader class]]`
1329-
*/
1330-
@implementation RCTBridge (RCTImageLoader)
1331-
1332-
- (RCTImageLoader *)imageLoader
1333-
{
1334-
RCTLogWarn(
1335-
@"Calling bridge.imageLoader is deprecated and will not work in newer versions of RN. Please update to the "
1336-
"moduleForClass API or turboModuleRegistry API.");
1337-
return [self moduleForClass:[RCTImageLoader class]];
1338-
}
1339-
1340-
@end
1341-
13421326
@implementation RCTBridgeProxy (RCTImageLoader)
13431327

13441328
- (RCTImageLoader *)imageLoader

‎packages/react-native/Libraries/Image/RCTImageStoreManager.mm‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -248,15 +248,6 @@ - (void)getImageForTag:(NSString *)imageTag withBlock:(void (^)(UIImage *image))
248248

249249
@end
250250

251-
@implementation RCTBridge (RCTImageStoreManager)
252-
253-
- (RCTImageStoreManager *)imageStoreManager
254-
{
255-
return [self moduleForClass:[RCTImageStoreManager class]];
256-
}
257-
258-
@end
259-
260251
@implementation RCTBridgeProxy (RCTImageStoreManager)
261252

262253
- (RCTImageStoreManager *)imageStoreManager

‎packages/react-native/Libraries/Network/RCTNetworking.mm‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -856,15 +856,6 @@ - (void)clearCookies:(RCTResponseSenderBlock)responseSender
856856

857857
@end
858858

859-
@implementation RCTBridge (RCTNetworking)
860-
861-
- (RCTNetworking *)networking
862-
{
863-
return [self moduleForClass:[RCTNetworking class]];
864-
}
865-
866-
@end
867-
868859
@implementation RCTBridgeProxy (RCTNetworking)
869860

870861
- (RCTNetworking *)networking

‎packages/react-native/React/Base/RCTEventDispatcher.m‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,6 @@
2020
return eventName;
2121
}
2222

23-
@implementation RCTBridge (RCTEventDispatcher)
24-
25-
- (id<RCTEventDispatcherProtocol>)eventDispatcher
26-
{
27-
return [self moduleForName:@"EventDispatcher" lazilyLoadIfNecessary:YES];
28-
}
29-
30-
@end
31-
3223
@implementation RCTBridgeProxy (RCTEventDispatcher)
3324

3425
- (id<RCTEventDispatcherProtocol>)eventDispatcher

‎packages/react-native/React/CoreModules/RCTAccessibilityManager.mm‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -486,15 +486,6 @@ void RCTAccessibilityManagerSetIsVoiceOverEnabled(
486486

487487
@end
488488

489-
@implementation RCTBridge (RCTAccessibilityManager)
490-
491-
- (RCTAccessibilityManager *)accessibilityManager
492-
{
493-
return [self moduleForClass:[RCTAccessibilityManager class]];
494-
}
495-
496-
@end
497-
498489
@implementation RCTBridgeProxy (RCTAccessibilityManager)
499490

500491
- (RCTAccessibilityManager *)accessibilityManager

‎packages/react-native/React/CoreModules/RCTDevMenu.mm‎

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -616,19 +616,6 @@ + (instancetype)buttonItemWithTitleBlock:(NSString * (^)(void))titleBlock handle
616616

617617
#endif
618618

619-
@implementation RCTBridge (RCTDevMenu)
620-
621-
- (RCTDevMenu *)devMenu
622-
{
623-
#if RCT_DEV_MENU
624-
return [self moduleForClass:[RCTDevMenu class]];
625-
#else
626-
return nil;
627-
#endif
628-
}
629-
630-
@end
631-
632619
@implementation RCTBridgeProxy (RCTDevMenu)
633620

634621
- (RCTDevMenu *)devMenu

‎packages/react-native/React/CoreModules/RCTDevSettings.mm‎

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -552,21 +552,6 @@ - (void)addHandler:(id<RCTPackagerClientMethod>)handler forPackagerMethod:(NSStr
552552

553553
#endif // #if RCT_DEV_MENU
554554

555-
@implementation RCTBridge (RCTDevSettings)
556-
557-
- (RCTDevSettings *)devSettings
558-
{
559-
#if RCT_REMOTE_PROFILE
560-
return [self moduleForClass:[RCTDevSettings class]];
561-
#elif RCT_DEV_MENU
562-
return devSettingsMenuEnabled ? [self moduleForClass:[RCTDevSettings class]] : nil;
563-
#else
564-
return nil;
565-
#endif
566-
}
567-
568-
@end
569-
570555
@implementation RCTBridgeProxy (RCTDevSettings)
571556

572557
- (RCTDevSettings *)devSettings

‎packages/react-native/React/CoreModules/RCTWebSocketModule.mm‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -288,15 +288,6 @@ - (void)webSocket:(SRWebSocket *)webSocket
288288

289289
@end
290290

291-
@implementation RCTBridge (RCTWebSocketModule)
292-
293-
- (RCTWebSocketModule *)webSocketModule
294-
{
295-
return [self moduleForClass:[RCTWebSocketModule class]];
296-
}
297-
298-
@end
299-
300291
@implementation RCTBridgeProxy (RCTWebSocketModule)
301292

302293
- (RCTWebSocketModule *)webSocketModule

‎packages/react-native/React/Modules/RCTSurfacePresenterStub.m‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,6 @@
77

88
#import "RCTSurfacePresenterStub.h"
99

10-
@implementation RCTBridge (RCTSurfacePresenterStub)
11-
12-
- (id<RCTSurfacePresenterStub>)surfacePresenter
13-
{
14-
return objc_getAssociatedObject(self, @selector(surfacePresenter));
15-
}
16-
17-
- (void)setSurfacePresenter:(id<RCTSurfacePresenterStub>)surfacePresenter
18-
{
19-
objc_setAssociatedObject(self, @selector(surfacePresenter), surfacePresenter, OBJC_ASSOCIATION_RETAIN);
20-
}
21-
22-
@end
23-
2410
@implementation RCTBridgeProxy (RCTSurfacePresenterStub)
2511

2612
- (id<RCTSurfacePresenterStub>)surfacePresenter

0 commit comments

Comments
 (0)