Skip to content

Commit 03cb9bb

Browse files
feat(extensions): migrate to NFS (#2527)
* feat(extensions): migrate to NFS * Fix tests for extensions nfs --------- Co-authored-by: sanketpathak <spathak@redhat.com>
1 parent 8751f81 commit 03cb9bb

74 files changed

Lines changed: 5025 additions & 2127 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@red-hat-developer-hub/backstage-plugin-extensions': minor
3+
---
4+
5+
Migrated plugin to NFS

workspaces/extensions/.eslintignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
playwright.config.ts
2+
e2e-tests/
23
.eslintrc.js
34
.prettierrc.js
45
coverage

workspaces/extensions/.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,5 @@ site
5151
*.session.sql
5252

5353
# E2E test reports
54-
e2e-test-report/
54+
e2e-test-report*/
5555
test-results/

workspaces/extensions/app-config.yaml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,22 @@
11
app:
22
title: Backstage App
33
baseUrl: http://localhost:3000
4+
packages: all
5+
6+
extensions:
7+
- page:catalog:
8+
config:
9+
path: /
10+
- api:app/app-language:
11+
config:
12+
availableLanguages: ['en', 'de', 'es', 'fr', 'it', 'ja']
13+
defaultLanguage: 'en'
14+
- nav-item:user-settings: false
15+
- nav-item:search: false
16+
- nav-item:home: false
17+
- nav-item:catalog:
18+
config:
19+
title: 'Home'
420

521
organization:
622
name: My Company
@@ -128,6 +144,11 @@ permission:
128144
pluginsWithPermission:
129145
- catalog
130146
- extensions
147+
admin:
148+
superUsers:
149+
- name: user:development/guest
150+
users:
151+
- name: user:development/guest
131152

132153
extensions:
133154
# directory: ../../examples # YAML files are in the examples directory

workspaces/extensions/packages/app/e2e-tests/extensions.test.ts renamed to workspaces/extensions/e2e-tests/extensions.test.ts

Lines changed: 31 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import { test, expect, Page, type BrowserContext } from '@playwright/test';
1818
import { Extensions } from './pages/extensions';
1919
import { runAccessibilityTests } from './utils/accessibility';
2020
import { ExtensionHelper } from './utils/helper';
21-
import { skipIfLocales } from './utils/localeSkip';
2221
import { ExtensionsMessages, getTranslations } from './utils/translations';
2322

2423
/**
@@ -124,10 +123,10 @@ test.describe('Admin > Extensions', () => {
124123
test('Verify support type filters in extensions', async ({
125124
browser: _browser,
126125
}, testInfo) => {
127-
skipIfLocales(
128-
testInfo,
129-
['de', 'es'],
130-
'Missing badges in de/es - https://issues.redhat.com/browse/RHDHBUGS-2793',
126+
// Below can be removed after bug https://redhat.atlassian.net/browse/RHDHBUGS-2821 is fixed
127+
test.fixme(
128+
testInfo.project.name === 'es' || testInfo.project.name === 'de',
129+
'Skip Spanish and German tests',
131130
);
132131
await extensions.selectDropdown(`${translations.search.supportType}`);
133132
await extensions.supportFilters();
@@ -137,10 +136,10 @@ test.describe('Admin > Extensions', () => {
137136
test('Verify certified badge in extensions', async ({
138137
browser: _browser,
139138
}, testInfo) => {
140-
skipIfLocales(
141-
testInfo,
142-
['de', 'es'],
143-
'Missing badges in de/es - https://issues.redhat.com/browse/RHDHBUGS-2793',
139+
// Below can be removed after bug https://redhat.atlassian.net/browse/RHDHBUGS-2821 is fixed
140+
test.fixme(
141+
testInfo.project.name === 'es' || testInfo.project.name === 'de',
142+
'Skip Spanish and German tests',
144143
);
145144
await extensions.selectDropdown(`${translations.search.supportType}`);
146145
await extensions.toggleOption(translations.badges.certified);
@@ -171,10 +170,10 @@ test.describe('Admin > Extensions', () => {
171170
test('Verify Generally available badge in extensions', async ({
172171
browser: _browser,
173172
}, testInfo) => {
174-
skipIfLocales(
175-
testInfo,
176-
['de', 'es'],
177-
'Missing badges in de/es - https://issues.redhat.com/browse/RHDHBUGS-2793',
173+
// Below can be removed after bug https://redhat.atlassian.net/browse/RHDHBUGS-2821 is fixed
174+
test.fixme(
175+
testInfo.project.name === 'es' || testInfo.project.name === 'de',
176+
'Skip Spanish and German tests',
178177
);
179178
await extensions.selectSupportTypeFilter(
180179
translations.badges.generallyAvailable,
@@ -208,10 +207,10 @@ test.describe('Admin > Extensions', () => {
208207
test('Verify custom plugin badge in extensions', async ({
209208
browser: _browser,
210209
}, testInfo) => {
211-
skipIfLocales(
212-
testInfo,
213-
['de', 'es'],
214-
'Missing badges in de/es - https://issues.redhat.com/browse/RHDHBUGS-2793',
210+
// Below can be removed after bug https://redhat.atlassian.net/browse/RHDHBUGS-2821 is fixed
211+
test.fixme(
212+
testInfo.project.name === 'es' || testInfo.project.name === 'de',
213+
'Skip Spanish and German tests',
215214
);
216215
await extensions.selectSupportTypeFilter(
217216
translations.badges.customPlugin,
@@ -238,10 +237,10 @@ test.describe('Admin > Extensions', () => {
238237
test('Verify tech preview badge in extensions', async ({
239238
browser: _browser,
240239
}, testInfo) => {
241-
skipIfLocales(
242-
testInfo,
243-
['de', 'es'],
244-
'Missing badges in de/es - https://issues.redhat.com/browse/RHDHBUGS-2793',
240+
// Below can be removed after bug https://redhat.atlassian.net/browse/RHDHBUGS-2821 is fixed
241+
test.fixme(
242+
testInfo.project.name === 'es' || testInfo.project.name === 'de',
243+
'Skip Spanish and German tests',
245244
);
246245
await extensions.verifySupportTypeBadge({
247246
supportType: translations.badges.techPreview,
@@ -255,11 +254,13 @@ test.describe('Admin > Extensions', () => {
255254
});
256255
});
257256

258-
test('Verify dev preview badge in extensions', async ({}, testInfo) => {
259-
skipIfLocales(
260-
testInfo,
261-
['de', 'es'],
262-
'Missing badges in de/es - https://issues.redhat.com/browse/RHDHBUGS-2793',
257+
test('Verify dev preview badge in extensions', async ({
258+
browser: _browser,
259+
}, testInfo) => {
260+
// Below can be removed after bug https://redhat.atlassian.net/browse/RHDHBUGS-2821 is fixed
261+
test.fixme(
262+
testInfo.project.name === 'es' || testInfo.project.name === 'de',
263+
'Skip Spanish and German tests',
263264
);
264265
await extensions.selectSupportTypeFilter(translations.badges.devPreview);
265266
await extensionHelper.verifyHeading('Extensions');
@@ -278,10 +279,10 @@ test.describe('Admin > Extensions', () => {
278279
test('Verify community plugin badge in extensions', async ({
279280
browser: _browser,
280281
}, testInfo) => {
281-
skipIfLocales(
282-
testInfo,
283-
['de', 'es'],
284-
'Missing badges in de/es - https://issues.redhat.com/browse/RHDHBUGS-2793',
282+
// Below can be removed after bug https://redhat.atlassian.net/browse/RHDHBUGS-2821 is fixed
283+
test.fixme(
284+
testInfo.project.name === 'es' || testInfo.project.name === 'de',
285+
'Skip Spanish and German tests',
285286
);
286287
await extensions.selectSupportTypeFilter(
287288
translations.badges.communityPlugin,

workspaces/extensions/packages/app/e2e-tests/pages/extensions.ts renamed to workspaces/extensions/e2e-tests/pages/extensions.ts

File renamed without changes.

workspaces/extensions/packages/app/e2e-tests/utils/accessibility.ts renamed to workspaces/extensions/e2e-tests/utils/accessibility.ts

File renamed without changes.

workspaces/extensions/packages/app/e2e-tests/utils/helper.ts renamed to workspaces/extensions/e2e-tests/utils/helper.ts

File renamed without changes.

workspaces/extensions/packages/app/e2e-tests/utils/translations.ts renamed to workspaces/extensions/e2e-tests/utils/translations.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616

1717
// These translation files are not exported by the package, so relative imports are necessary for e2e tests
1818
/* eslint-disable @backstage/no-relative-monorepo-imports */
19-
import { extensionsMessages } from '../../../../plugins/extensions/src/translations/ref.js';
20-
import extensionsTranslationDe from '../../../../plugins/extensions/src/translations/de.js';
21-
import extensionsTranslationEs from '../../../../plugins/extensions/src/translations/es.js';
22-
import extensionsTranslationFr from '../../../../plugins/extensions/src/translations/fr.js';
23-
import extensionsTranslationIt from '../../../../plugins/extensions/src/translations/it.js';
24-
import extensionsTranslationJa from '../../../../plugins/extensions/src/translations/ja.js';
19+
import { extensionsMessages } from '../../plugins/extensions/src/alpha/translations/ref.js';
20+
import extensionsTranslationDe from '../../plugins/extensions/src/alpha/translations/de.js';
21+
import extensionsTranslationEs from '../../plugins/extensions/src/alpha/translations/es.js';
22+
import extensionsTranslationFr from '../../plugins/extensions/src/alpha/translations/fr.js';
23+
import extensionsTranslationIt from '../../plugins/extensions/src/alpha/translations/it.js';
24+
import extensionsTranslationJa from '../../plugins/extensions/src/alpha/translations/ja.js';
2525
/* eslint-enable @backstage/no-relative-monorepo-imports */
2626

2727
export type ExtensionsMessages = typeof extensionsMessages;

workspaces/extensions/package.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
},
88
"scripts": {
99
"start": "backstage-cli repo start",
10+
"start:legacy": "yarn start app-legacy backend",
1011
"start-backend": "yarn workspace backend start",
1112
"build:backend": "yarn workspace backend build",
1213
"tsc": "tsc",
@@ -19,7 +20,10 @@
1920
"clean": "backstage-cli repo clean",
2021
"test": "backstage-cli repo test --detectOpenHandles",
2122
"test:all": "backstage-cli repo test --coverage --detectOpenHandles",
22-
"test:e2e": "playwright test",
23+
"test:legacy": "APP_MODE=legacy playwright test",
24+
"test:nfs": "APP_MODE=nfs playwright test",
25+
"test:e2e:ci": "yarn test:legacy && yarn test:nfs",
26+
"playwright": "sh -c 'if [ \"$1\" = test ] && [ $# -eq 1 ]; then yarn test:e2e:ci; else exec playwright \"$@\"; fi' _",
2327
"fix": "backstage-cli repo fix",
2428
"lint": "backstage-cli repo lint --since origin/main",
2529
"lint:all": "backstage-cli repo lint",

0 commit comments

Comments
 (0)