refactor(scorecard): improve e2e tests with specific card error checks (#2254)

* refactor(scorecard): improve e2e tests with specific card error checks

- Add expectCardHasMissingPermission helper to HomePage
- Add expectCardHasNoDataFound helper to HomePage
- Update tests to verify error states on specific GitHub and Jira cards
- Remove redundant expectCardVisible calls

* style: fix prettier formatting in CatalogPage.ts

---------

Co-authored-by: HusneShabbir <husneshabbir447@gmail.com>

Author: HusneShabbir

workspaces/scorecard/packages/app/e2e-tests/pages/CatalogPage.ts

@@ -49,6 +49,9 @@ export class CatalogPage {
 
   async openComponent(componentName: string) {
     const link = this.page.getByRole('link', { name: componentName });
+    await this.page
+      .getByRole('textbox', { name: 'Search' })
+      .fill(componentName);
     await expect(link).toBeVisible({ timeout: 10000 });
     await link.click();
   }

workspaces/scorecard/packages/app/e2e-tests/pages/HomePage.ts

@@ -87,4 +87,23 @@ export class HomePage {
       this.page.getByText(percentage, { exact: true }),
     ).toBeVisible();
   }
+
+  async expectCardHasMissingPermission(
+    metricId: 'github.open_prs' | 'jira.open_issues',
+  ) {
+    const card = this.getCard(metricId);
+    await expect(card).toContainText(
+      this.translations.errors.missingPermissionMessage,
+    );
+  }
+
+  async expectCardHasNoDataFound(
+    metricId: 'github.open_prs' | 'jira.open_issues',
+  ) {
+    const card = this.getCard(metricId);
+    await expect(card).toContainText(this.translations.errors.noDataFound);
+    await expect(card).toContainText(
+      this.translations.errors.noDataFoundMessage,
+    );
+  }
 }

workspaces/scorecard/packages/app/e2e-tests/scorecard.test.ts

@@ -202,6 +202,9 @@ test.describe('Scorecard Plugin Tests', () => {
           entityCount,
         ),
       );
+
+      await homePage.expectCardHasMissingPermission('github.open_prs');
+      await homePage.expectCardHasMissingPermission('jira.open_issues');
     });
 
     test('Manage scorecards on Home page', async () => {
@@ -276,15 +279,9 @@ test.describe('Scorecard Plugin Tests', () => {
 
       await homePage.navigateToHome();
       await page.reload();
-      await homePage.expectCardVisible('github.open_prs');
-      await homePage.expectCardVisible('jira.open_issues');
 
-      await expect(page.locator('article')).toContainText(
-        translations.errors.noDataFound,
-      );
-      await expect(page.locator('article')).toContainText(
-        translations.errors.noDataFoundMessage,
-      );
+      await homePage.expectCardHasNoDataFound('github.open_prs');
+      await homePage.expectCardHasNoDataFound('jira.open_issues');
     });
 
     test('Verify threshold tooltips', async () => {